hackedteam/vector-edk

View on GitHub
AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py

Summary

Maintainability
F
1 wk
Test Coverage

File pickletools.py has 1760 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'''"Executable documentation" for the pickle module.

Extensive comments about the pickle protocols and pickle-machine opcodes
can be found here.  Some functions meant for external use:
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 4 days to fix

    Function dis has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
    Open

    def dis(pickle, out=None, memo=None, indentlevel=4):
        """Produce a symbolic disassembly of a pickle.
    
        'pickle' is a file-like object, or string, containing a (at least one)
        pickle.  The pickle is disassembled from the current position, through
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function assure_pickle_consistency has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    def assure_pickle_consistency(verbose=False):
        import pickle, re
    
        copy = code2op.copy()
        for name in pickle.__all__:
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function genops has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    def genops(pickle):
        """Generate all the opcodes in a pickle.
    
        'pickle' is a file-like object, or string, containing the pickle.
    
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function read_stringnl has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def read_stringnl(f, decode=True, stripquotes=True):
        r"""
        >>> import StringIO
        >>> read_stringnl(StringIO.StringIO("'abcd'\nefg\n"))
        'abcd'
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function optimize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def optimize(p):
        'Optimize a pickle string by removing unused PUT opcodes'
        gets = set()            # set of args used by a GET opcode
        puts = []               # (arg, startpos, stoppos) for the PUT opcodes
        prevpos = None          # set to pos if previous opcode was a PUT
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, name, code, arg,
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/pickletools.py - About 50 mins to fix

      There are no issues that match your filters.

      Category
      Status