Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/random.py

Summary

Maintainability
F
1 mo
Test Coverage

File random.py has 589 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Random variable generators.

    integers
    --------
           uniform within range
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 1 day to fix

    Function gammavariate has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        def gammavariate(self, alpha, beta):
        """Gamma distribution.  Not the gamma function!

        Conditions on the parameters are alpha > 0 and beta > 0.
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Random has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Random(_random.Random):
    """Random number generator base class used by bound module functions.

    Used to instantiate instances of Random to get generators that don't
    share state.  Especially useful for multi-threaded programs, creating
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 2 hrs to fix

      Function randrange has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          def randrange(self, start, stop=None, step=1, int=int, default=None,
                  maxwidth=1L<<BPF):
        """Choose a random item from range(start, stop[, step]).

        This fixes the problem with randint() which includes the
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function sample has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          def sample(self, population, k):
        """Chooses k unique random elements from a population sequence.

        Returns a new list containing elements from the population while
        leaving the original population unchanged.  The resulting list is
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function randrange has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def randrange(self, start, stop=None, step=1, int=int, default=None,
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 45 mins to fix

        Function _randbelow has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _randbelow(self, n, _log=_log, int=int, _maxwidth=1L<<BPF,
        Severity: Minor
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 45 mins to fix

          Function _randbelow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def _randbelow(self, n, _log=_log, int=int, _maxwidth=1L<<BPF,
                   _Method=_MethodType, _BuiltinMethod=_BuiltinMethodType):
        """Return a random int in the range [0,n)

        Handles the case where n has more bits than returned
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function vonmisesvariate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def vonmisesvariate(self, mu, kappa):
        """Circular data distribution.

        mu is the mean angle, expressed in radians between 0 and 2*pi, and
        kappa is the concentration parameter, which must be greater than or
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return istart + istep*self._randbelow(n)
          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return istart + istep*int(self.random() * n)
            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Lib/random.py and 1 other location - About 1 mo to fix
              vector-uefi/fd/efi/StdLib/lib/python.27/random.py on lines 0..908

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 4835.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status