Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py

Summary

Maintainability
F
1 mo
Test Coverage

File shutil.py has 440 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Utility functions for copying and archiving files and directory trees.

XXX The functions here don't copy the resource fork or other metadata on Mac.

"""
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 6 hrs to fix

    Function _make_zipfile has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    def _make_zipfile(base_name, base_dir, verbose=0, dry_run=0, logger=None):
    """Create a zip file from all the files under 'base_dir'.

    The output zip file will be named 'base_name' + ".zip".  Uses either the
    "zipfile" Python module (if available) or the InfoZIP "zip" utility
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function copytree has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    def copytree(src, dst, symlinks=False, ignore=None):
    """Recursively copy a directory tree using copy2().

    The destination directory must not already exist.
    If exception(s) occur, an Error is raised with a list of reasons.
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function rmtree has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def rmtree(path, ignore_errors=False, onerror=None):
    """Recursively delete a directory tree.

    If ignore_errors is set, errors are ignored; otherwise, if onerror
    is set, it is called to handle the error with arguments (func,
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function move has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def move(src, dst):
    """Recursively move a file or directory to another location. This is
    similar to the Unix "mv" command.

    If the destination is a directory or a symlink to a directory, the source
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function make_archive has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0,
                 dry_run=0, owner=None, group=None, logger=None):
    """Create an archive file (eg. zip or tar).

    'base_name' is the name of the file to create, minus any format-specific
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _make_tarball has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def _make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0,
                  owner=None, group=None, logger=None):
    """Create a (possibly compressed) tar file from all the files under
    'base_dir'.
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function make_archive has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def make_archive(base_name, format, root_dir=None, base_dir=None, verbose=0,
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

      Function copystat has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      def copystat(src, dst):
    """Copy all stat info (mode bits, atime, mtime, flags) from src to dst"""
    st = os.stat(src)
    mode = stat.S_IMODE(st.st_mode)
    if hasattr(os, 'utime'):
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _make_tarball has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _make_tarball(base_name, base_dir, compress="gzip", verbose=0, dry_run=0,
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                            if os.path.isfile(path):
                        zip.write(path, path)
                        if logger is not None:
                            logger.info("adding '%s'", path)
            zip.close()
        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 45 mins to fix

          Function _make_zipfile has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _make_zipfile(base_name, base_dir, verbose=0, dry_run=0, logger=None):
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 35 mins to fix

            Function copyfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def copyfile(src, dst):
    """Copy data from src to dst"""
    if _samefile(src, dst):
        raise Error("`%s` and `%s` are the same file" % (src, dst))
            Severity: Minor
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function register_archive_format has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def register_archive_format(name, function, extra_args=None, description=''):
    """Registers an archive format.

    name is the name of the format. function is the callable that will be
    used to create archives. If provided, extra_args is a sequence of
            Severity: Minor
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Lib/shutil.py and 1 other location - About 1 mo to fix
            vector-uefi/fd/efi/StdLib/lib/python.27/shutil.py on lines 0..552

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 2921.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status