Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/string.py

Summary

Maintainability
F
3 wks
Test Coverage

File string.py has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""A collection of string operations (most are no longer used).

Warning: most of the code you see here isn't normally used nowadays.
Beginning with Python 1.6, many of these functions are implemented as
methods on the standard string object. They used to be implemented by
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 5 hrs to fix

    Function safe_substitute has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def safe_substitute(self, *args, **kws):
        if len(args) > 1:
            raise TypeError('Too many positional arguments')
        if not args:
            mapping = kws
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function substitute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def substitute(self, *args, **kws):
        if len(args) > 1:
            raise TypeError('Too many positional arguments')
        if not args:
            mapping = kws
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _vformat has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _vformat(self, format_string, args, kwargs, used_args, recursion_depth):
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

                      return self.delimiter
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return self.delimiter
        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 30 mins to fix

          Function _vformat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _vformat(self, format_string, args, kwargs, used_args, recursion_depth):
        if recursion_depth < 0:
            raise ValueError('Max string recursion exceeded')
        result = []
        for literal_text, field_name, format_spec, conversion in \
          Severity: Minor
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/string.py and 1 other location - About 3 wks to fix
          vector-uefi/fd/efi/StdLib/lib/python.27/string.py on lines 0..642

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 2159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status