Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py

Summary

Maintainability
F
2 wks
Test Coverage

File xmlbuilder.py has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Implementation of the DOM Level 3 'LS-Load' feature."""

import copy
import xml.dom
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if name == "infoset":
                options = self._options
                return (options.datatype_normalization
                        and options.whitespace_in_element_content
                        and options.comments
    Severity: Critical
    Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py - About 1 hr to fix

      Function setFeature has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def setFeature(self, name, state):
        if self.supportsFeature(name):
            state = state and 1 or 0
            try:
                settings = self._settings[(_name_xform(name), state)]
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _guess_media_encoding has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _guess_media_encoding(self, source):
        info = source.byteStream.info()
        if "Content-Type" in info:
            for param in info.getplist():
                if param.startswith("charset="):
      Severity: Minor
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/dom/xmlbuilder.py and 1 other location - About 2 wks to fix
      vector-uefi/fd/efi/StdLib/lib/python.27/xml/dom/xmlbuilder.py on lines 0..386

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 1922.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status