Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py

Summary

Maintainability
F
4 days
Test Coverage

Function main has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
Open

def main():
    # overridable context
    prefix = None                       # settable with -p option
    exec_prefix = None                  # settable with -P option
    extensions = []
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File freeze.py has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#! /usr/bin/env python

"""Freeze a Python script into a binary.

usage: freeze [options...] script [module]...
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py - About 4 hrs to fix

    Function main has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def main():
    # overridable context
    prefix = None                       # settable with -p option
    exec_prefix = None                  # settable with -P option
    extensions = []
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for file in supp_sources:
        if not os.path.exists(file):
            usage('needed file %s not found' % file)
        if not os.path.isfile(file):
            usage('%s: not a plain file' % file)
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py and 1 other location - About 3 hrs to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py on lines 253..257

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          for dir in check_dirs:
        if not os.path.exists(dir):
            usage('needed directory %s not found' % dir)
        if not os.path.isdir(dir):
            usage('%s: not a directory' % dir)
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py and 1 other location - About 3 hrs to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/freeze/freeze.py on lines 262..266

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status