Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/ndiff.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function main has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def main(args):
    import getopt
    try:
        opts, args = getopt.getopt(args, "qr:")
    except getopt.error, detail:
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/ndiff.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return fail("-r value must be 1 or 2")
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/ndiff.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return fcompare(f1name, f2name)
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/ndiff.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return fail("need 2 filename args")
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/ndiff.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status