Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/pysource.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function walk_python_files has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

def walk_python_files(paths, is_python=looks_like_python, exclude_dirs=None):
    """\
    Recursively yield all Python source files below the given paths.

    paths: a list of files and/or directories to be checked.
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/pysource.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if is_python(fullpath):
                        yield fullpath
        else:
Severity: Major
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/pysource.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if exclude in dirnames:
                        dirnames.remove(exclude)
                for filename in filenames:
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/pysource.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

          return False
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Tools/scripts/pysource.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status