Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py

Summary

Maintainability
D
2 days
Test Coverage

File tktools.py has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Assorted Tk-related subroutines used in Grail."""


from types import *
from Tkinter import *
Severity: Minor
Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 2 hrs to fix

    Function make_scrollbars has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def make_scrollbars(parent, hbar, vbar, pack=1, class_=None, name=None,
                    takefocus=0):

    """Subroutine to create a frame with scrollbars.
    Severity: Minor
    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function make_text_box has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def make_text_box(parent, width=0, height=0, hbar=0, vbar=1,
    Severity: Major
    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 1 hr to fix

      Function make_canvas has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def make_canvas(parent, width=0, height=0, hbar=1, vbar=1,
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 1 hr to fix

        Function make_list_box has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def make_list_box(parent, width=0, height=0, hbar=0, vbar=1,
        Severity: Major
        Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 1 hr to fix

          Function make_labeled_form_entry has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def make_labeled_form_entry(parent, label, entrywidth=20, entryheight=1,
          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 50 mins to fix

            Function make_scrollbars has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def make_scrollbars(parent, hbar, vbar, pack=1, class_=None, name=None,
            Severity: Major
            Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 50 mins to fix

              Function make_group_frame has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def make_group_frame(master, name=None, label=None, fill=Y,
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 50 mins to fix

                Function make_double_frame has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                def make_double_frame(master=None, class_=None, name=None, relief=RAISED,
                      borderwidth=1):
    """Create a pair of frames suitable for 'hosting' a dialog."""
    if name:
        if class_: frame = Frame(master, class_=class_, name=name)
                Severity: Minor
                Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function make_double_frame has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def make_double_frame(master=None, class_=None, name=None, relief=RAISED,
                Severity: Minor
                Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 35 mins to fix

                  Function set_transient has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def set_transient(widget, master, relx=0.5, rely=0.3, expose=1):
                  Severity: Minor
                  Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 35 mins to fix

                    Function make_labeled_form_entry has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def make_labeled_form_entry(parent, label, entrywidth=20, entryheight=1,
                            labelwidth=0, borderwidth=None,
                            takefocus=None):
    """Subroutine to create a form entry.
                    Severity: Minor
                    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if name:
        if class_: frame = Frame(master, class_=class_, name=name)
        else: frame = Frame(master, name=name)
    else:
        if class_: frame = Frame(master, class_=class_)
                    Severity: Major
                    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py and 1 other location - About 3 hrs to fix
                    AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py on lines 77..82

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if class_:
        if name: frame = Frame(parent, class_=class_, name=name)
        else: frame = Frame(parent, class_=class_)
    else:
        if name: frame = Frame(parent, name=name)
                    Severity: Major
                    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py and 1 other location - About 3 hrs to fix
                    AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py on lines 281..286

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if hbar:
        widget['xscrollcommand'] = (hbar, 'set')
        hbar['command'] = (widget, 'xview')
                    Severity: Minor
                    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py and 1 other location - About 30 mins to fix
                    AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py on lines 122..124

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if vbar:
        widget['yscrollcommand'] = (vbar, 'set')
        vbar['command'] = (widget, 'yview')
                    Severity: Minor
                    Found in AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py and 1 other location - About 30 mins to fix
                    AppPkg/Applications/Python/Python-2.7.2/Tools/webchecker/tktools.py on lines 126..128

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status