Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
BaseTools/Source/Python/CommonDataClass/DataClass.py

Summary

Maintainability
C
1 day
Test Coverage

Function __init__ has 16 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, ID = -1, Header = '', Modifier = '', Name = '', ReturnStatement = '', \
Severity: Major
Found in BaseTools/Source/Python/CommonDataClass/DataClass.py - About 2 hrs to fix

    Function __init__ has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, ID = -1, CName = '', TokenSpaceGuidCName = '', Token = '', DatumType = '', Model = MODEL_UNKNOWN, \
    Severity: Major
    Found in BaseTools/Source/Python/CommonDataClass/DataClass.py - About 1 hr to fix

      Function __init__ has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, ID = -1, Modifier = '', Type = '', Name = '', Value = '', Model = MODEL_UNKNOWN, \
      Severity: Major
      Found in BaseTools/Source/Python/CommonDataClass/DataClass.py - About 1 hr to fix

        Function __init__ has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, ID = -1, Name = '', ExtName = '', Path = '', FullPath = '', Model = MODEL_UNKNOWN, TimeStamp = '', \
        Severity: Major
        Found in BaseTools/Source/Python/CommonDataClass/DataClass.py - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def __init__(self, ID = -1, Modifier = '', Type = '', Name = '', Value = '', Model = MODEL_UNKNOWN, \
                 BelongsToFile = -1, BelongsToFunction = -1, StartLine = -1, StartColumn = -1, EndLine = -1, EndColumn = -1):
        self.ID = ID
        self.Modifier = Modifier
        self.Type = Type
          Severity: Major
          Found in BaseTools/Source/Python/CommonDataClass/DataClass.py and 1 other location - About 4 hrs to fix
          BaseTools/Source/Python/Workspace/WorkspaceDatabase.py on lines 1178..1190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 85.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status