hackedteam/vector-edk

View on GitHub
BaseTools/Source/Python/Eot/CodeFragment.py

Summary

Maintainability
C
1 day
Test Coverage

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, ModifierStr, DeclStr, Begin, End, LBPos, NamePos):
Severity: Minor
Found in BaseTools/Source/Python/Eot/CodeFragment.py - About 45 mins to fix

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, Lvalue, Op, Exp, Begin, End):
    Severity: Minor
    Found in BaseTools/Source/Python/Eot/CodeFragment.py - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      class FunctionDefinition :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 1 other location - About 2 hrs to fix
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 69..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

      class VariableDeclaration :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 7 other locations - About 1 hr to fix
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 89..101
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 138..150
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 152..164
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 156..168
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 173..185

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

      class Comment :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 7 other locations - About 1 hr to fix
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 89..101
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 138..150
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 152..164
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 107..119
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 156..168
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 173..185

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

      class TypedefDefinition :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 7 other locations - About 1 hr to fix
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 89..101
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 138..150
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 152..164
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 107..119
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 173..185

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

      class FunctionCalling:
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 7 other locations - About 1 hr to fix
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 89..101
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 138..150
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 152..164
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 19..32
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 107..119
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 156..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

      class EnumerationDefinition :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 10 other locations - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/framer/framer/structparse.py on lines 10..14
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 14..18
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 50..54
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 53..64
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 106..117
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 122..133
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 71..82
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 140..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

      class PP_Directive :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 10 other locations - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/framer/framer/structparse.py on lines 10..14
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 14..18
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 50..54
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 53..64
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 106..117
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 122..133
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 71..82
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 124..135
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 140..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

      class PredicateExpression :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 10 other locations - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/framer/framer/structparse.py on lines 10..14
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 14..18
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 50..54
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 53..64
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 106..117
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 122..133
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 124..135
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 140..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

      class StructUnionDefinition :
          ## The constructor
          #
          #   @param  self        The object pointer
          #   @param  Str         The message to record
      Severity: Major
      Found in BaseTools/Source/Python/Eot/CodeFragment.py and 10 other locations - About 30 mins to fix
      AppPkg/Applications/Python/Python-2.7.2/Tools/framer/framer/structparse.py on lines 10..14
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 14..18
      AppPkg/Applications/Python/Python-2.7.2/Tools/pybench/Instances.py on lines 50..54
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 53..64
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 106..117
      BaseTools/Source/Python/Ecc/CodeFragment.py on lines 122..133
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 37..48
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 71..82
      BaseTools/Source/Python/Eot/CodeFragment.py on lines 124..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status