Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
BaseTools/Source/Python/GenFds/Section.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function GetFileList has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    def GetFileList(FfsInf, FileType, FileExtension, Dict = {}):
        if FileType in Section.SectFileType.keys() :
            IsSect = True
        else :
            IsSect = False
Severity: Minor
Found in BaseTools/Source/Python/GenFds/Section.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GenSection has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def GenSection(self, OutputPath, GuidName, SecNum, keyStringList, FfsInf = None, Dict = {}):
Severity: Minor
Found in BaseTools/Source/Python/GenFds/Section.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if '*' in FfsInf.TargetOverrideList or File.Target == '*' or File.Target in FfsInf.TargetOverrideList or FfsInf.TargetOverrideList == []:
                            FileList.append(FfsInf.PatchEfiFile(File.Path))
                        else:
                            GenFdsGlobalVariable.InfLogger ("\nBuild Target \'%s\' of File %s is not in the Scope of %s specified by INF %s in FDF" %(File.Target, File.File, FfsInf.TargetOverrideList, FfsInf.InfFileName))
                    else:
    Severity: Major
    Found in BaseTools/Source/Python/GenFds/Section.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status