Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
BaseTools/Source/Python/UPT/Parser/DecParserMisc.py

Summary

Maintainability
D
2 days
Test Coverage

Function IsValidPcdDatum has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

def IsValidPcdDatum(Type, Value):
    if Type not in ["UINT8", "UINT16", "UINT32", "UINT64", "VOID*", "BOOLEAN"]:
        return False, ST.ERR_DECPARSE_PCD_TYPE
    if Type == "VOID*":
        if not ((Value.startswith('L"') or Value.startswith('"') and \
Severity: Minor
Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function IsValidCArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def IsValidCArray(Array):
    Par = ParserHelper(Array)
    if not Par.Expect('{'):
        return False
    if Par.End():
Severity: Minor
Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function IsValidNList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def IsValidNList(Value):
    Par = ParserHelper(Value)
    if Par.End():
        return False
    while not Par.End():
Severity: Minor
Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if not ((Value.startswith('L"') or Value.startswith('"') and \
                 Value.endswith('"'))
                or (IsValidCArray(Value)) or (IsValidCFormatGuid(Value)) \
                or (IsValidNList(Value)) or (CheckGuidRegFormat(Value))
               ):
Severity: Major
Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 1 hr to fix

    Function GetToken has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def GetToken(self, StopChar='.,|\t ', SkipPair='"'):
        self.__SkipWhitespace()
        PreIndex = self._Index
        InQuote = False
        LastChar = ''
    Severity: Minor
    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return False
    Severity: Major
    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return False, Cause
      Severity: Major
      Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return Par.End()
        Severity: Major
        Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return False, ST.ERR_DECPARSE_PCD_INT_NEGTIVE % (Value, Type)
          Severity: Major
          Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return True, ""
            Severity: Major
            Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return True, ""
              Severity: Major
              Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return False, ST.ERR_DECPARSE_PCD_INT % (Value, Type)
                Severity: Major
                Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return False, ST.ERR_DECPARSE_PCD_INT_EXCEED % (StrVal, Type)
                  Severity: Major
                  Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 30 mins to fix

                    Function CleanString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def CleanString(Line, CommentCharacter=TAB_COMMENT_SPLIT, \
                AllowCppStyleComment=False):
    #
    # remove whitespace
    #
                    Severity: Minor
                    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if Line[Index] == CommentCharacter and not InQuote:
            Comment = Line[Index:].strip()
            Line = Line[0:Index].strip()
            break
                    Severity: Major
                    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py and 1 other location - About 2 hrs to fix
                    BaseTools/Source/Python/Common/String.py on lines 398..403

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        def __SkipWhitespace(self):
        for Char in self._String[self._Index:]:
            if Char not in ' \t':
                break
            self._Index += 1
                    Severity: Major
                    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py and 2 other locations - About 1 hr to fix
                    BaseTools/Source/Python/Common/Expression.py on lines 384..388
                    BaseTools/Source/Python/UPT/Library/ExpressionValidate.py on lines 88..92

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 42.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if Char == '\\' and LastChar == '\\':
                LastChar = ''
            else:
                LastChar = Char
                    Severity: Minor
                    Found in BaseTools/Source/Python/UPT/Parser/DecParserMisc.py and 1 other location - About 30 mins to fix
                    BaseTools/Source/Python/UPT/Library/String.py on lines 821..824

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status