Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py

Summary

Maintainability
F
2 wks
Test Coverage

File config.py has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""distutils.command.config

Implements the Distutils 'config' command, a (mostly) empty command class
that exists mainly to be sub-classed by specific module distributions and
applications.  The idea is that while every "config" command is different,
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 2 hrs to fix

    Function check_func has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def check_func(self, func, headers=None, include_dirs=None,
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 50 mins to fix

      Function try_link has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def try_link(self, body, headers=None, include_dirs=None, libraries=None,
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 45 mins to fix

        Function try_run has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def try_run(self, body, headers=None, include_dirs=None, libraries=None,
        Severity: Minor
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 45 mins to fix

          Function _link has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def _link(self, body, headers, include_dirs, libraries, library_dirs,
          Severity: Minor
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 45 mins to fix

            Function check_lib has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def check_lib(self, library, library_dirs=None, headers=None,
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 35 mins to fix

              Function search_cpp has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def search_cpp(self, pattern, body=None, headers=None, include_dirs=None,
              Severity: Minor
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 35 mins to fix

                Function finalize_options has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def finalize_options(self):
        if self.include_dirs is None:
            self.include_dirs = self.distribution.include_dirs or []
        elif isinstance(self.include_dirs, str):
            self.include_dirs = self.include_dirs.split(os.pathsep)
                Severity: Minor
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _check_compiler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    def _check_compiler(self):
        """Check that 'self.compiler' really is a CCompiler object;
        if not, make it one.
        """
        # We do this late, and only on-demand, because this is an expensive
                Severity: Minor
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function search_cpp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def search_cpp(self, pattern, body=None, headers=None, include_dirs=None,
                   lang="c"):
        """Construct a source file (just like 'try_cpp()'), run it through
        the preprocessor, and return true if any line of the output matches
        'pattern'.  'pattern' should either be a compiled regex object or a
                Severity: Minor
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/command/config.py and 1 other location - About 2 wks to fix
                AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/command/config.py on lines 0..357

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 1699.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status