Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py

Summary

Maintainability
F
1 mo
Test Coverage

Function _parsegen has a Cognitive Complexity of 167 (exceeds 5 allowed). Consider refactoring.
Open

    def _parsegen(self):
        # Create a new message and start by parsing headers.
        self._new_message()
        headers = []
        # Collect the headers, searching for a line that doesn't match the RFC
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File feedparser.py has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright (C) 2004-2006 Python Software Foundation
# Authors: Baxter, Wouters and Warsaw
# Contact: email-sig@python.org

"""FeedParser - An email feed parser.
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 4 hrs to fix

    Function _parse_headers has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def _parse_headers(self, lines):
        # Passed a list of lines that make up the headers for the current msg
        lastheader = ''
        lastvalue = []
        for lineno, line in enumerate(lines):
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if epilogue == '':
                            self._last.epilogue = None
                        elif epilogue is not None:
                            mo = NLCRE_eol.search(epilogue)
                            if mo:
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if not mo:
                            self._input.unreadline(line)
                            break
                    # Recurse to parse this subpart; the input stream points
                    # at the subpart's first line.
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if retval is NeedMoreData:
                            yield NeedMoreData
                            continue
                        break
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if preamble:
                            # According to RFC 2046, the last newline belongs
                            # to the boundary.
                            lastline = preamble[-1]
                            eolmo = NLCRE_eol.search(lastline)
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if line is NeedMoreData:
                            yield NeedMoreData
                            continue
                        mo = boundaryre.match(line)
            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if isinstance(payload, basestring):
                            mo = NLCRE_eol.search(payload)
                            if mo:
                                payload = payload[:-len(mo.group(0))]
                                self._last.set_payload(payload)
              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 45 mins to fix

                Avoid too many return statements within this function.
                Open

                            return
                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return
                  Severity: Major
                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 30 mins to fix

                    Function readline has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def readline(self):
        if not self._lines:
            if self._closed:
                return ''
            return NeedMoreData
                    Severity: Minor
                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    Severity: Major
                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/email/feedparser.py and 1 other location - About 3 wks to fix
                    AppPkg/Applications/Python/Python-2.7.2/Lib/email/feedparser.py on lines 0..484

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 2628.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status