Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py

Summary

Maintainability
F
1 mo
Test Coverage

Function _make_iterencode has a Cognitive Complexity of 120 (exceeds 5 allowed). Consider refactoring.
Open

def _make_iterencode(markers, _default, _encoder, _indent, _floatstr,
        _key_separator, _item_separator, _sort_keys, _skipkeys, _one_shot,
        ## HACK: hand-optimized bytecode; turn globals into locals
        ValueError=ValueError,
        basestring=basestring,
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File encoder.py has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Implementation of JSONEncoder
"""
import re

try:
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 5 hrs to fix

    Function _make_iterencode has 22 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _make_iterencode(markers, _default, _encoder, _indent, _floatstr,
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 2 hrs to fix

      Function iterencode has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def iterencode(self, o, _one_shot=False):
        """Encode the given object and yield each string
        representation as available.

        For example::
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function encode has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def encode(self, o):
        """Return a JSON string representation of a Python data structure.

        >>> JSONEncoder().encode({"foo": ["bar", "baz"]})
        '{"foo": ["bar", "baz"]}'
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, skipkeys=False, ensure_ascii=True,
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 1 hr to fix

        Function py_encode_basestring_ascii has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def py_encode_basestring_ascii(s):
    """Return an ASCII-only JSON representation of a Python string

    """
    if isinstance(s, str) and HAS_UTF8.search(s) is not None:
        Severity: Minor
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/encoder.py and 1 other location - About 3 wks to fix
        AppPkg/Applications/Python/Python-2.7.2/Lib/json/encoder.py on lines 0..442

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 2331.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status