Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py

Summary

Maintainability
F
1 wk
Test Coverage

Function py_make_scanner has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

def py_make_scanner(context):
    parse_object = context.parse_object
    parse_array = context.parse_array
    parse_string = context.parse_string
    match_number = NUMBER_RE.match
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return False, idx + 5
Severity: Major
Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return True, idx + 4
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return parse_constant('-Infinity'), idx + 9
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return res, m.end()
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return parse_constant('NaN'), idx + 3
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return parse_constant('Infinity'), idx + 8
            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/json/scanner.py and 1 other location - About 6 days to fix
              AppPkg/Applications/Python/Python-2.7.2/Lib/json/scanner.py on lines 0..67

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 666.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status