hackedteam/vector-edk

View on GitHub
vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py

Summary

Maintainability
F
1 mo
Test Coverage

Function _parse_doctype_subset has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    def _parse_doctype_subset(self, i, declstartpos):
        rawdata = self.rawdata
        n = len(rawdata)
        j = i
        while j < n:
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _parse_doctype_attlist has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    def _parse_doctype_attlist(self, i, declstartpos):
        rawdata = self.rawdata
        name, j = self._scan_name(i, declstartpos)
        c = rawdata[j:j+1]
        if c == "":
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parse_declaration has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_declaration(self, i):
        # This is some sort of declaration; in "HTML as
        # deployed," this should only be the document type
        # declaration ("<!DOCTYPE html...>").
        # ISO 8879:1986, however, has more complex
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _parse_doctype_entity has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def _parse_doctype_entity(self, i, declstartpos):
        rawdata = self.rawdata
        if rawdata[i:i+1] == "%":
            j = i + 1
            while 1:
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File markupbase.py has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Shared support for scanning document type declarations in HTML and XHTML.

This module is used as a foundation for the HTMLParser and sgmllib
modules (indirectly, for htmllib as well).  It has no documented
public API and should not be used directly.
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 3 hrs to fix

    Function _parse_doctype_notation has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        def _parse_doctype_notation(self, i, declstartpos):
            name, j = self._scan_name(i, declstartpos)
            if j < 0:
                return j
            rawdata = self.rawdata
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return j
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return -1 # incomplete
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return -1
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return -1
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return j + 1
            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                  return -1 # incomplete
              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                    return -1
                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return j
                  Severity: Major
                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return -1
                    Severity: Major
                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return j
                      Severity: Major
                      Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return -1
                        Severity: Major
                        Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return -1
                          Severity: Major
                          Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return j + 1
                            Severity: Major
                            Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                  return j
                              Severity: Major
                              Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                    return j
                                Severity: Major
                                Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                                  return j
                                  Severity: Major
                                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                        return -1
                                    Severity: Major
                                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                              return j
                                      Severity: Major
                                      Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                            return -1
                                        Severity: Major
                                        Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                              return -1
                                          Severity: Major
                                          Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                                return -1
                                            Severity: Major
                                            Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                                  return j
                                              Severity: Major
                                              Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                                return -1
                                                Severity: Major
                                                Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                                  return j + 1
                                                  Severity: Major
                                                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 30 mins to fix

                                                    Function parse_marked_section has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                        def parse_marked_section(self, i, report=1):
                                                            rawdata= self.rawdata
                                                            assert rawdata[i:i+3] == '<![', "unexpected call to parse_marked_section()"
                                                            sectName, j = self._scan_name( i+3, i )
                                                            if j < 0:
                                                    Severity: Minor
                                                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py - About 25 mins to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Identical blocks of code found in 2 locations. Consider refactoring.
                                                    Open

                                                    Severity: Major
                                                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/markupbase.py and 1 other location - About 1 mo to fix
                                                    AppPkg/Applications/Python/Python-2.7.2/Lib/markupbase.py on lines 0..391

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 2873.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    There are no issues that match your filters.

                                                    Category
                                                    Status