Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py

Summary

Maintainability
F
1 mo
Test Coverage

Function _format has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
Open

    def _format(self, object, stream, indent, allowance, context, level):
        level = level + 1
        objid = _id(object)
        if objid in context:
            stream.write(_recursion(object))
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _safe_repr has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

def _safe_repr(object, context, maxlevels, level):
    typ = _type(object)
    if typ is str:
        if 'locale' not in _sys.modules:
            return repr(object), True, False
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File pprint.py has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#  Author:      Fred L. Drake, Jr.
#               fdrake@acm.org
#
#  This is a simple little module I wrote to make life easier.  I didn't
#  see anything quite like it in the library, though I may have overlooked
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if ((issubclass(typ, list) and r is list.__repr__) or
            (issubclass(typ, tuple) and r is tuple.__repr__) or
            (issubclass(typ, set) and r is set.__repr__) or
            (issubclass(typ, frozenset) and r is frozenset.__repr__)
           ):
    Severity: Critical
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 1 hr to fix

      Function _format has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _format(self, object, stream, indent, allowance, context, level):
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if sepLines:
                            write(',\n%s%s: ' % (' '*indent, rep))
                        else:
                            write(', %s: ' % rep)
                        self._format(ent, stream, indent + _len(rep) + 2,
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if sepLines:
                            write(',\n' + ' '*indent)
                        else:
                            write(', ')
                        self._format(ent, stream, indent,
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 45 mins to fix

            Function pprint has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def pprint(object, stream=None, indent=1, width=80, depth=None):
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                          return format % "...", False, objid in context
              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return "[]", True, False
                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return
                  Severity: Major
                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return "{%s}" % _commajoin(components), readable, recursive
                    Severity: Major
                    Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return format % _commajoin(components), readable, recursive
                      Severity: Major
                      Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return _recursion(object), False, True
                        Severity: Major
                        Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return
                          Severity: Major
                          Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return _recursion(object), False, True
                            Severity: Major
                            Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                  return rep, (rep and not rep.startswith('<')), False
                              Severity: Major
                              Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                return "()", True, False
                                Severity: Major
                                Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py - About 30 mins to fix

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                  Severity: Major
                                  Found in vector-uefi/fd/efi/StdLib/lib/python.27/pprint.py and 1 other location - About 3 wks to fix
                                  AppPkg/Applications/Python/Python-2.7.2/Lib/pprint.py on lines 0..350

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 2508.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status