Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py

Summary

Maintainability
F
3 wks
Test Coverage

Function _readmodule has a Cognitive Complexity of 152 (exceeds 5 allowed). Consider refactoring.
Open

def _readmodule(module, path, inpackage=None):
    '''Do the hard work for readmodule[_ex].

    If INPACKAGE is given, it must be the dotted name of the package in
    which we are searching for a submodule, and then PATH must be the
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File pyclbr.py has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Parse a Python module and describe its classes and methods.

Parse enough of a Python file to recognize imports and class and
method definitions, and to find out the superclasses of a class.
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 2 hrs to fix

    Function _main has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def _main():
    # Main program for testing.
    import os
    mod = sys.argv[1]
    if os.path.exists(mod):
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _getnamelist has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def _getnamelist(g):
    # Helper to get a comma-separated list of dotted names plus 'as'
    # clauses.  Return a list of pairs (name, name2) where name2 is
    # the 'as' name, or None if there is no 'as' clause.
    names = []
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if token in (')', ',') and level == 1:
                            n = "".join(super)
                            if n in dict:
                                # we know this super class
                                n = dict[n]
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if token == '(':
                            level += 1
                        elif token == ')':
                            level -= 1
                            if level == 0:
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                for n in d:
                            if n[0] != '_':
                                dict[n] = d[n]
    except StopIteration:
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 45 mins to fix

          Consider simplifying this complex logical expression.
          Open

                      if tokentype == DEDENT:
                lineno, thisindent = start
                # close nested classes and defs
                while stack and stack[-1][1] >= thisindent:
                    del stack[-1]
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 40 mins to fix

            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, module, name, super, file, lineno):
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                  return dict
              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 30 mins to fix

                Function _getname has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def _getname(g):
    # Helper to get a dotted name, return a pair (name, token) where
    # name is the dotted name, or None if there was no dotted name,
    # and token is the next input token.
    parts = []
                Severity: Minor
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/pyclbr.py and 1 other location - About 3 wks to fix
                AppPkg/Applications/Python/Python-2.7.2/Lib/pyclbr.py on lines 0..342

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 2159.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status