Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py

Summary

Maintainability
F
1 mo
Test Coverage

Function _compile has a Cognitive Complexity of 92 (exceeds 5 allowed). Consider refactoring.
Open

def _compile(code, pattern, flags):
    # internal: compile a (sub)pattern
    emit = code.append
    _len = len
    LITERAL_CODES = _LITERAL_CODES
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _compile_info has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
Open

def _compile_info(code, pattern, flags):
    # internal: compile an info block.  in the current version,
    # this contains min/max pattern width, and an optional literal
    # prefix or a character map
    lo, hi = pattern.getwidth()
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File sre_compile.py has 424 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# Secret Labs' Regular Expression Engine
#
# convert template to internal format
#
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 6 hrs to fix

    Function _optimize_charset has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    def _optimize_charset(charset, fixup):
    # internal: optimize character set
    out = []
    outappend = out.append
    charmap = [0]*256
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _optimize_unicode has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    def _optimize_unicode(charset, fixup):
    try:
        import array
    except ImportError:
        return charset
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _compile_charset has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def _compile_charset(charset, flags, code, fixup=None):
    # compile charset subprogram
    emit = code.append
    if fixup is None:
        fixup = _identityfunction
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        for p in av[1]:
                        if not p:
                            break
                        op, av = p[0]
                        if op is LITERAL:
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if op is LITERAL:
                        cappend((op, av))
                    else:
                        break
                else:
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if not p:
                        break
                    op, av = p[0]
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 45 mins to fix

          Function _mk_bitmap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          def _mk_bitmap(bits):
    data = []
    dataappend = data.append
    if _sre.CODESIZE == 2:
        start = (1, 0)
          Severity: Minor
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return charset
          Severity: Major
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return [(BIGCHARSET, data)]
            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              Severity: Major
              Found in vector-uefi/fd/efi/StdLib/lib/python.27/sre_compile.py and 1 other location - About 1 mo to fix
              AppPkg/Applications/Python/Python-2.7.2/Lib/sre_compile.py on lines 0..523

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 4354.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status