Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py

Summary

Maintainability
F
1 mo
Test Coverage

File tempfile.py has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Temporary files.

This module provides generic, low- and high-level interfaces for
creating temporary files and directories.  The interfaces listed
as "safe" just below can be used without fear of race conditions.
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 6 hrs to fix

    SpooledTemporaryFile has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SpooledTemporaryFile:
    """Temporary file wrapper, specialized to switch from
    StringIO to a real file when it exceeds a certain size or
    when a fileno is needed.
    """
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 3 hrs to fix

      Function _get_default_tempdir has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      def _get_default_tempdir():
    """Calculate the default directory to use for temporary files.
    This routine should be called exactly once.

    We determine whether or not a candidate temp dir is usable by
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _candidate_tempdir_list has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      def _candidate_tempdir_list():
    """Generate a list of candidate temporary directories which
    _get_default_tempdir will try."""

    dirlist = []
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, max_size=0, mode='w+b', bufsize=-1,
      Severity: Minor
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 45 mins to fix

        Function NamedTemporaryFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def NamedTemporaryFile(mode='w+b', bufsize=-1, suffix="",
        Severity: Minor
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 45 mins to fix

          Function TemporaryFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def TemporaryFile(mode='w+b', bufsize=-1, suffix="",
          Severity: Minor
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 35 mins to fix

            Function mkdtemp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def mkdtemp(suffix="", prefix=template, dir=None):
    """User-callable function to create and return a unique temporary
    directory.  The return value is the pathname of the directory.

    Arguments are as for mkstemp, except that the 'text' argument is
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function TemporaryFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def TemporaryFile(mode='w+b', bufsize=-1, suffix="",
                      prefix=template, dir=None):
        """Create and return a temporary file.
        Arguments:
        'prefix', 'suffix', 'dir' -- as for mkstemp.
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _mkstemp_inner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def _mkstemp_inner(dir, pre, suf, flags):
    """Code common to mkstemp, TemporaryFile, and NamedTemporaryFile."""

    names = _get_candidate_names()
            Severity: Minor
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/tempfile.py and 1 other location - About 3 wks to fix
            AppPkg/Applications/Python/Python-2.7.2/Lib/tempfile.py on lines 0..606

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 2545.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status