Sign upLogin

hackedteam/vector-edk

View on GitHub
Star
vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py

Summary

Maintainability
F
1 mo
Test Coverage

Function generate_tokens has a Cognitive Complexity of 97 (exceeds 5 allowed). Consider refactoring.
Open

def generate_tokens(readline):
    """
    The generate_tokens() generator requires one argment, readline, which
    must be a callable object which provides the same interface as the
    readline() method of built-in file objects. Each call to the function
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tokenize.py has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Tokenization help for Python programs.

generate_tokens(readline) is a generator that breaks a stream of
text into Python tokens.  It accepts a readline-like method which is called
repeatedly to get the next line of input (or "" for EOF).  It generates
Severity: Minor
Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 4 hrs to fix

    Function compat has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def compat(self, token, iterable):
        startline = False
        indents = []
        toks_append = self.tokens.append
        toknum, tokval = token
    Severity: Minor
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if token[-1] == '\n':                  # continued string
                        strstart = (lnum, start)
                        endprog = (endprogs[initial] or endprogs[token[1]] or
                                   endprogs[token[2]])
                        contstr, needcont = line[start:], 1
    Severity: Major
    Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if endmatch:                           # all on one line
                        pos = endmatch.end(0)
                        token = line[start:pos]
                        yield (STRING, token, spos, (lnum, pos), line)
                    else:
      Severity: Major
      Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if initial in '([{':
                        parenlev += 1
                    elif initial in ')]}':
                        parenlev -= 1
                    yield (OP, token, spos, epos, line)
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 45 mins to fix

          Function printtoken has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def printtoken(type, token, srow_scol, erow_ecol, line): # for testing
          Severity: Minor
          Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py - About 35 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/tokenize.py and 1 other location - About 1 mo to fix
            AppPkg/Applications/Python/Python-2.7.2/Lib/tokenize.py on lines 0..424

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 2736.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status