Sign upLogin

hackedteam/vector-exploit

View on GitHub
Star

Showing 389 of 389 total issues

Function findindex has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

ELFObject.prototype.findindex = function(name) {
    if (this.hashtab === undefined) {
    this.hashtab = {};
    this.hashtab.addr = this.dyntable['hashtab'];
    this.hashtab.nbucket = this.memobj.read32(this.hashtab.addr);
Severity: Minor
Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _read_7z_aes256_sha256 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _read_7z_aes256_sha256(self, coder, input):
        if not self._archive.password:
            raise NoPasswordGivenError()
        
        # TODO: this needs some sanity checks
Severity: Minor
Found in ht-2013-003-Powerpoint/pylzma.egg/py7zlib.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _read_7z_aes256_sha256 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _read_7z_aes256_sha256(self, coder, input):
        if not self._archive.password:
            raise NoPasswordGivenError()
        
        # TODO: this needs some sanity checks
Severity: Minor
Found in ht-2013-002-Word/pylzma.egg/py7zlib.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decrypt has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def decrypt(self, cipherIn, originalsize, mode, key, size, IV):
Severity: Minor
Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

    Function stage3_alternate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function stage3_alternate(memobj, node, addr, page, libwebcore, libc) {
    Severity: Minor
    Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

      Function xslt_exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function xslt_exploit(iframe, xml, base, documentarea, pagenum) {

    documentarea += 56;
    documentarea += 4;
      Severity: Minor
      Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          with open(apk_path, 'rb') as f:
                        data = s.recv(1025)
                        if(data.strip() == "ready"):
                            time.sleep(2)
                            logging.info('Sending file {}..'.format(apk_path))
      Severity: Major
      Found in src/ht-webkit-Android23/exp_server.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if firstRound:
                            plaintext[i] = IV[i] ^ output[i]
                        else:
                            plaintext[i] = iput[i] ^ output[i]
                    firstRound = False
        Severity: Major
        Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

          Function forkingcall has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          RCE.prototype.forkingcall = function(fn, r0, r1, r2, r3, r4) {
          Severity: Minor
          Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if len(output)-1 < i:
                            plaintext[i] = 0 ^ ciphertext[i]
                        elif len(ciphertext)-1 < i:
                            plaintext[i] = output[i] ^ 0
                        elif len(output)-1 < i and len(ciphertext) < i:
            Severity: Major
            Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

              Function decrypt has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def decrypt(self, cipherIn, originalsize, mode, key, size, IV):
              Severity: Minor
              Found in src/ht-webkit-Android4-src/ext/slowaes.py - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                if (window.ERR === undefined) {
    ERR = function() {
        window.location.replace("${B_REDIRECT_URI}");
    throw Error();
    };
                Severity: Minor
                Found in src/ht-webkit-Android4-src/src/stage4.js and 1 other location - About 45 mins to fix
                src/ht-webkit-Android4-src/precompiled/debug/stage4.js on lines 12..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid deeply nested control flow statements.
                Open

                                        if len(plaintext)-1 < i:
                            ciphertext[i] = 0 ^ output[i]
                        elif len(output)-1 < i:
                            ciphertext[i] = plaintext[i] ^ 0
                        elif len(plaintext)-1 < i and len(output) < i:
                Severity: Major
                Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          for k in range(end-start):
                            stringOut += chr(plaintext[k])
                    iput = ciphertext
                  Severity: Major
                  Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                    Function main has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def main():

    parser = argparse.ArgumentParser(
        description="Android Browser 4.0.x-4.3 remote exploit EDN build script"
    )
                    Severity: Minor
                    Found in src/ht-webkit-Android4-src/src/edn_build.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                            if ch == '\0\0':
                            f['filename'] = unicode(name, 'utf-16')
                            break
                        name += ch
                    Severity: Major
                    Found in ht-2013-004-IE/pylzma.egg/py7zlib.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if firstRound:
                            iput[i] =  plaintext[i] ^ IV[i]
                        else:
                            iput[i] =  plaintext[i] ^ ciphertext[i]
                    # print 'IP@%s:%s' % (j, iput)
                      Severity: Major
                      Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if firstRound:
                            plaintext[i] = IV[i] ^ output[i]
                        else:
                            plaintext[i] = iput[i] ^ output[i]
                    firstRound = False
                        Severity: Major
                        Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if firstRound:
                            iput[i] =  plaintext[i] ^ IV[i]
                        else:
                            iput[i] =  plaintext[i] ^ ciphertext[i]
                    # print 'IP@%s:%s' % (j, iput)
                          Severity: Major
                          Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if len(output)-1 < i:
                            plaintext[i] = 0 ^ ciphertext[i]
                        elif len(ciphertext)-1 < i:
                            plaintext[i] = output[i] ^ 0
                        elif len(output)-1 < i and len(ciphertext) < i:
                            Severity: Major
                            Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language