Sign upLogin

hackedteam/vector-exploit

View on GitHub
Star

Showing 389 of 389 total issues

Avoid too many return statements within this function.
Open

                    return
Severity: Major
Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return
    Severity: Major
    Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                              return
      Severity: Major
      Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return
        Severity: Major
        Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                          return
          Severity: Major
          Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return
            Severity: Major
            Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return
              Severity: Major
              Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                    return
                Severity: Major
                Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return
                  Severity: Major
                  Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return
                    Severity: Major
                    Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return
                      Severity: Major
                      Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return
                        Severity: Major
                        Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return
                          Severity: Major
                          Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        xor_key = ''.join([ random.choice(string.digits) for i in range(0,8)])
                            Severity: Minor
                            Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py and 1 other location - About 30 mins to fix
                            src/ht-webkit-Android23/add_exploit_instance.py on lines 20..20

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                    try:
                            current_exploit.socket_server_lock.release()
                            current_exploit.socket.shutdown(socket.SHUT_RDWR)
                            current_exploit.socket.close()
                            Severity: Minor
                            Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py and 1 other location - About 30 mins to fix
                            src/ht-webkit-Android23/webkit_rc3_plus_tea.py on lines 382..385

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    try:
            self.socket_server_lock.release()
            self.socket.shutdown(socket.SHUT_RDWR)
            self.socket.close()
                            Severity: Minor
                            Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py and 1 other location - About 30 mins to fix
                            src/ht-webkit-Android23/webkit_rc3_plus_tea.py on lines 1555..1558

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    candidate = ''.join([random.choice(string.digits) for i in range(0, 10) ] )
                            Severity: Minor
                            Found in src/ht-webkit-Android23/add_exploit_instance.py and 1 other location - About 30 mins to fix
                            src/ht-webkit-Android23/webkit_rc3_plus_tea.py on lines 219..219

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 32.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Function list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                def list(self, verbose=True):
        print 'total %d files in %sarchive' % (self.numfiles, (self.solid and 'solid ') or '')
        if not verbose:
            print '\n'.join(self.filenames)
            return
                            Severity: Minor
                            Found in ht-2013-003-Powerpoint/pylzma.egg/py7zlib.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function _readBoolean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                def _readBoolean(self, file, count, checkall=0):
        if checkall:
            alldefined = file.read(1)
            if alldefined != '\x00':
                return [True] * count
                            Severity: Minor
                            Found in ht-2013-002-Word/pylzma.egg/py7zlib.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function bisect_check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function bisect_check(bisect_firsthalf, bisect_secondhalf, addr) {
    // INFO("bisect_check " + addr);

    var iframe = document.createElement("iframe");
                            Severity: Minor
                            Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language