hadmean/hadmean

View on GitHub
src/frontend/views/settings/Data/index.tsx

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Function DateSettings has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function DateSettings() {
  const domainMessages = useAppConfigurationDomainMessages(
    "default_date_format"
  );

Severity: Major
Found in src/frontend/views/settings/Data/index.tsx - About 2 hrs to fix

    Function MetaDataSettings has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function MetaDataSettings() {
      const domainMessages = useAppConfigurationDomainMessages("metadata_columns");
    
      const metaDataColumns = useAppConfiguration("metadata_columns");
    
    
    Severity: Minor
    Found in src/frontend/views/settings/Data/index.tsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            <ViewStateMachine
              loading={metaDataColumns.isLoading}
              error={metaDataColumns.error}
              loader={
                <FormSkeleton
      Severity: Major
      Found in src/frontend/views/settings/Data/index.tsx and 1 other location - About 1 hr to fix
      src/frontend/views/users/DatabaseLink/index.tsx on lines 97..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

            <ViewStateMachine
              loading={defaultDateFormat.isLoading}
              error={defaultDateFormat.error}
              loader={<FormSkeleton schema={[FormSkeletonSchema.Input]} />}
            >
      Severity: Major
      Found in src/frontend/views/settings/Data/index.tsx and 4 other locations - About 55 mins to fix
      src/frontend/views/account/Preferences/index.tsx on lines 84..98
      src/frontend/views/account/Profile/index.tsx on lines 35..47
      src/frontend/views/entity/Presentation/index.tsx on lines 76..110
      src/frontend/views/settings/System/index.tsx on lines 45..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                fields={{
                  format: {
                    label: msg`Format`,
                    type: "text",
                    validations: [
      Severity: Minor
      Found in src/frontend/views/settings/Data/index.tsx and 1 other location - About 35 mins to fix
      src/frontend/views/integrations/Password.tsx on lines 30..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status