hairyhenderson/passport-fellowshipone

View on GitHub

Showing 7 of 7 total issues

Function _performSecureRequest has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

Strategy.prototype._performSecureRequest = function (oauthToken, oauthTokenSecret, method, url, extraParams, postBody, postContentType, callback) {
  /* jshint shadow: true, sub: true, eqnull: true */
  var orderedParameters = this._prepareParameters(oauthToken, oauthTokenSecret, method, url, extraParams)

  if (!postContentType) {
Severity: Minor
Found in lib/passport-fellowshipone/strategy.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _performSecureRequest has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Strategy.prototype._performSecureRequest = function (oauthToken, oauthTokenSecret, method, url, extraParams, postBody, postContentType, callback) {
  /* jshint shadow: true, sub: true, eqnull: true */
  var orderedParameters = this._prepareParameters(oauthToken, oauthTokenSecret, method, url, extraParams)

  if (!postContentType) {
Severity: Major
Found in lib/passport-fellowshipone/strategy.js - About 4 hrs to fix

    Function transform has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    Strategy.prototype.transform = function (err, items, done) {
      if (err) return done(err)
    
      if (!items[0].person) return done(new InternalOAuthError('Fellowship One returned invalid reply object %s', items[0]))
      if (!items[1].communications) return done(new InternalOAuthError('Fellowship One returned invalid reply object %s', items[1]))
    Severity: Minor
    Found in lib/passport-fellowshipone/strategy.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function transform has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Strategy.prototype.transform = function (err, items, done) {
      if (err) return done(err)
    
      if (!items[0].person) return done(new InternalOAuthError('Fellowship One returned invalid reply object %s', items[0]))
      if (!items[1].communications) return done(new InternalOAuthError('Fellowship One returned invalid reply object %s', items[1]))
    Severity: Minor
    Found in lib/passport-fellowshipone/strategy.js - About 1 hr to fix

      Function _performSecureRequest has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Strategy.prototype._performSecureRequest = function (oauthToken, oauthTokenSecret, method, url, extraParams, postBody, postContentType, callback) {
      Severity: Major
      Found in lib/passport-fellowshipone/strategy.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ((method === 'POST' || method === 'PUT') && postBody != null && postBody !== '') {
              request.write(postBody)
            }
        Severity: Minor
        Found in lib/passport-fellowshipone/strategy.js and 1 other location - About 35 mins to fix
        lib/passport-fellowshipone/strategy.js on lines 238..240

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ((method === 'POST' || method === 'PUT') && postBody != null && postBody !== '') {
              request.write(postBody)
            }
        Severity: Minor
        Found in lib/passport-fellowshipone/strategy.js and 1 other location - About 35 mins to fix
        lib/passport-fellowshipone/strategy.js on lines 233..235

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language