Sign upLogin

hakimel/reveal.js

View on GitHub
Star

Showing 210 of 210 total issues

Function formatEmbeddedContent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    formatEmbeddedContent() {

        let _appendParamToIframeSource = ( sourceAttribute, sourceURL, param ) => {
            queryAll( this.Reveal.getSlidesElement(), 'iframe['+ sourceAttribute +'*="'+ sourceURL +'"]' ).forEach( el => {
                let src = el.getAttribute( sourceAttribute );
Severity: Minor
Found in js/controllers/slidecontent.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return null;
Severity: Major
Found in js/utils/color.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return value;
    Severity: Major
    Found in js/utils/util.js - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if( !contrastColor || !colorToRgb( contrastColor ) ) {
            let computedBackgroundStyle = window.getComputedStyle( element );
            if( computedBackgroundStyle && computedBackgroundStyle.backgroundColor ) {
                contrastColor = computedBackgroundStyle.backgroundColor;
            }
      Severity: Minor
      Found in js/controllers/backgrounds.js and 1 other location - About 30 mins to fix
      js/controllers/printview.js on lines 51..56

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if( viewportElement ) {
            const viewportStyles = window.getComputedStyle( viewportElement );
            if( viewportStyles && viewportStyles.background ) {
                presentationBackground = viewportStyles.background;
            }
      Severity: Minor
      Found in js/controllers/printview.js and 1 other location - About 30 mins to fix
      js/controllers/backgrounds.js on lines 219..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function colorToRgb has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export const colorToRgb = ( color ) => {

    let hex3 = color.match( /^#([0-9a-f]{3})$/i );
    if( hex3 && hex3[1] ) {
        hex3 = hex3[1];
      Severity: Minor
      Found in js/utils/color.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toggle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          toggle( override ) {

        if( typeof override === 'boolean' ) {
            override ? this.activate() : this.deactivate();
        }
      Severity: Minor
      Found in js/controllers/overview.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function configure has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          configure( config, oldConfig ) {

        let slideNumberDisplay = 'none';
        if( config.slideNumber && !this.Reveal.isPrintView() ) {
            if( config.showSlideNumber === 'all' ) {
      Severity: Minor
      Found in js/controllers/slidenumber.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function deserialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export const deserialize = ( value ) => {

    if( typeof value === 'string' ) {
        if( value === 'null' ) return null;
        else if( value === 'true' ) return true;
      Severity: Minor
      Found in js/utils/util.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toggle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          toggle( override ) {

        if( typeof override === 'boolean' ) {
            override ? this.activate() : this.deactivate();
        }
      Severity: Minor
      Found in js/controllers/scrollview.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language