haleks/laravel-markdown

View on GitHub

Showing 9 of 9 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function registerMarkdownBladeEngine($resolver)
    {
        $app = $this->app;

        $app->singleton('markdown.blade.compiler', function ($app) {
Severity: Major
Found in src/MarkdownServiceProvider.php and 2 other locations - About 2 hrs to fix
src/MarkdownServiceProvider.php on lines 175..190
src/MarkdownServiceProvider.php on lines 197..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function registerMarkdownEngine($resolver)
    {
        $app = $this->app;

        $app->singleton('markdown.compiler', function ($app) {
Severity: Major
Found in src/MarkdownServiceProvider.php and 2 other locations - About 2 hrs to fix
src/MarkdownServiceProvider.php on lines 197..212
src/MarkdownServiceProvider.php on lines 219..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected function registerMarkdownPhpEngine($resolver)
    {
        $app = $this->app;

        $app->singleton('markdown.php.compiler', function ($app) {
Severity: Major
Found in src/MarkdownServiceProvider.php and 2 other locations - About 2 hrs to fix
src/MarkdownServiceProvider.php on lines 175..190
src/MarkdownServiceProvider.php on lines 219..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getEchoMethods has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getEchoMethods()
    {
        $methods = [
            'compileRawEchos' => strlen(stripcslashes($this->rawTags[0])),
            'compileEscapedEchos' => strlen(stripcslashes($this->escapedTags[0])),
Severity: Minor
Found in src/Compilers/BladeExtCompiler.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return -1;
    Severity: Major
    Found in src/Compilers/BladeExtCompiler.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return 1;
      Severity: Major
      Found in src/Compilers/BladeExtCompiler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return -1;
        Severity: Major
        Found in src/Compilers/BladeExtCompiler.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return 1;
          Severity: Major
          Found in src/Compilers/BladeExtCompiler.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $methods;
            Severity: Major
            Found in src/Compilers/BladeExtCompiler.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language