Sign upLogin

hammackj/kekkan

View on GitHub
Star

Showing 13 of 13 total issues

Method parse_options has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def parse_options
                begin
                    opts = OptionParser.new do |opt|
                        opt.banner =    "#{Kekkan::APP_NAME} v#{Kekkan::VERSION}\nJacob Hammack\n#{Kekkan::SITE}\n\n"
                        opt.banner << "Usage: #{Kekkan::APP_NAME} [options] [files_to_parse]"
Severity: Major
Found in lib/kekkan/cli/application.rb - About 2 hrs to fix

    Method parse_options has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

                def parse_options
                begin
                    opts = OptionParser.new do |opt|
                        opt.banner =    "#{Kekkan::APP_NAME} v#{Kekkan::VERSION}\nJacob Hammack\n#{Kekkan::SITE}\n\n"
                        opt.banner << "Usage: #{Kekkan::APP_NAME} [options] [files_to_parse]"
    Severity: Minor
    Found in lib/kekkan/cli/application.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method up has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                def self.up
                create_table :entries do |t|
                    t.string :cve
                    t.string :published_datetime
                    t.string :last_modified_datetime
    Severity: Minor
    Found in lib/kekkan/base/schema.rb - About 1 hr to fix

      Method start_element has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  def start_element(element, attributes = [])
                @tag = element
                @vals[@tag] = ""

                if !@valid_elements.include?(element)
      Severity: Minor
      Found in lib/kekkan/parsers/cve_2_sax_listener.rb - About 1 hr to fix

        Method end_element has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    def end_element(element)
                #puts "End element: #{element}"
                @tag = nil
                case element
                    when "vuln:cve-id"
        Severity: Minor
        Found in lib/kekkan/parsers/cve_2_sax_listener.rb - About 1 hr to fix

          Method run has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      def run
                parse_options

                if @options[:debug]
                    puts "[*] Enabling Debug Mode"
          Severity: Minor
          Found in lib/kekkan/cli/application.rb - About 1 hr to fix

            Method migrate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                        def migrate direction
                begin
                    if @database["adapter"] == nil
                        return false, "[!] Invalid database adapter, please check your configuration file"
                    end
            Severity: Minor
            Found in lib/kekkan/cli/application.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method migrate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        def migrate direction
                begin
                    if @database["adapter"] == nil
                        return false, "[!] Invalid database adapter, please check your configuration file"
                    end
            Severity: Minor
            Found in lib/kekkan/cli/application.rb - About 1 hr to fix

              Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                          def run
                parse_options

                if @options[:debug]
                    puts "[*] Enabling Debug Mode"
              Severity: Minor
              Found in lib/kekkan/cli/application.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method load_config has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                          def load_config file=CONFIG_FILE, memory_config=false
                if File.exists?(file) == true or memory_config == true
                    begin
                        if memory_config
                            yaml = YAML::load(file)
              Severity: Minor
              Found in lib/kekkan/cli/application.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method db_connect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                          def db_connect
                begin
                    if @database["adapter"] == nil
                        puts "[!] #{@database['adapter']}" if @options[:debug]
              Severity: Minor
              Found in lib/kekkan/cli/application.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  when "vuln:definition"
                        @scanner = @entry.scanners.create
                        @scanner.attributes = {
                            :name => Hash[attributes]["name"],
                            :href => Hash[attributes]["href"],
              Severity: Minor
              Found in lib/kekkan/parsers/cve_2_sax_listener.rb and 1 other location - About 25 mins to fix
              lib/kekkan/parsers/cve_2_sax_listener.rb on lines 89..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  when "vuln:assessment_check "
                        @ass = @entry.assessment_check.create
                        @ass.attributes = {
                            :name => Hash[attributes]["name"],
                            :href => Hash[attributes]["href"],
              Severity: Minor
              Found in lib/kekkan/parsers/cve_2_sax_listener.rb and 1 other location - About 25 mins to fix
              lib/kekkan/parsers/cve_2_sax_listener.rb on lines 98..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 30.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language