Sign upLogin

happz/ducky

View on GitHub
Star
ducky/config.py

Summary

Maintainability
C
1 day
Test Coverage

MachineConfig has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class MachineConfig(ConfigParser):
  """
  Contains configuration of the whole VM, and provides methods for parsing,
  inspection and extending this configuration.
  """
Severity: Minor
Found in ducky/config.py - About 2 hrs to fix

    Function add_breakpoint has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def add_breakpoint(self, core, address, active = None, flip = None, ephemeral = None, countdown = None):
    Severity: Minor
    Found in ducky/config.py - About 45 mins to fix

      Function add_mmap has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def add_mmap(self, filepath, address, size, offset = None, access = None, shared = None):
      Severity: Minor
      Found in ducky/config.py - About 45 mins to fix

        Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def set(self, section, option, value, *args, **kwargs):
        Severity: Minor
        Found in ducky/config.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def getfloat(self, section, option, default = None):
    try:
      v = ConfigParser.get(self, section, option)
      return float(v) if v is not None else default
          Severity: Major
          Found in ducky/config.py and 1 other location - About 2 hrs to fix
          ducky/config.py on lines 57..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def getint(self, section, option, default = None):
    try:
      v = ConfigParser.get(self, section, option)
      return str2int(v) if v is not None else default
          Severity: Major
          Found in ducky/config.py and 1 other location - About 2 hrs to fix
          ducky/config.py on lines 82..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status