Sign upLogin

happz/ducky

View on GitHub
Star
ducky/cpu/coprocessor/math_copro.py

Summary

Maintainability
F
4 days
Test Coverage

File math_copro.py has 520 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
Stack-based coprocessor, providing several arithmetic operations with "long"
numbers.

Coprocessor's instructions operates on a stack of (by default) 8 slots.
Severity: Major
Found in ducky/cpu/coprocessor/math_copro.py - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class LOADW(Descriptor_MATH):
  """
  Take a value from register, extend it to ``long``, and make the result TOS.
  """
    Severity: Major
    Found in ducky/cpu/coprocessor/math_copro.py and 1 other location - About 1 day to fix
    ducky/cpu/coprocessor/math_copro.py on lines 355..385

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    class LOADUW(Descriptor_MATH):
  """
  Take a value from register, extend it to ``long``, and make the result TOS.
  """
    Severity: Major
    Found in ducky/cpu/coprocessor/math_copro.py and 1 other location - About 1 day to fix
    ducky/cpu/coprocessor/math_copro.py on lines 311..341

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      @staticmethod
  def assemble_operands(ctx, inst, operands):
    ctx.encode(inst, 'reg1', 5, operands[0].operand)
    ctx.encode(inst, 'reg2', 5, operands[1].operand)
    Severity: Major
    Found in ducky/cpu/coprocessor/math_copro.py and 2 other locations - About 2 hrs to fix
    ducky/cpu/coprocessor/math_copro.py on lines 465..468
    ducky/cpu/instructions.py on lines 416..419

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      @staticmethod
  def assemble_operands(ctx, inst, operands):
    ctx.encode(inst, 'reg1', 5, operands[0].operand)
    ctx.encode(inst, 'reg2', 5, operands[1].operand)
    Severity: Major
    Found in ducky/cpu/coprocessor/math_copro.py and 2 other locations - About 2 hrs to fix
    ducky/cpu/coprocessor/math_copro.py on lines 411..414
    ducky/cpu/instructions.py on lines 416..419

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status