Sign upLogin

happz/ducky

View on GitHub
Star
ducky/devices/rtc.py

Summary

Maintainability
C
1 day
Test Coverage

Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def __init__(self, machine, name, frequency = None, mmio_address = None, irq = None, *args, **kwargs):
Severity: Major
Found in ducky/devices/rtc.py - About 50 mins to fix

    Function read_u8 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def read_u8(self, offset):
    self.DEBUG('%s.read_u8: offset=%s', self.__class__.__name__, UINT8_FMT(offset))

    if offset == RTCPorts.FREQUENCY:
      return self._device.frequency
    Severity: Minor
    Found in ducky/devices/rtc.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return u8_t(now.day).value
    Severity: Major
    Found in ducky/devices/rtc.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return u8_t(now.year - 2000).value
      Severity: Major
      Found in ducky/devices/rtc.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return u8_t(now.month).value
        Severity: Major
        Found in ducky/devices/rtc.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return 0x00
          Severity: Major
          Found in ducky/devices/rtc.py - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            class HDTEntry_RTC(HDTEntry_Device):
  _fields_ = HDTEntry_Device.ENTRY_HEADER + [
    ('mmio_address', u32_t)
  ]
            Severity: Major
            Found in ducky/devices/rtc.py and 2 other locations - About 4 hrs to fix
            ducky/devices/keyboard.py on lines 24..34
            ducky/devices/tty.py on lines 31..41

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            class RTCPorts(enum.IntEnum):
  FREQUENCY = 0x00
  SECOND    = 0x01
  MINUTE    = 0x02
  HOUR      = 0x04
            Severity: Major
            Found in ducky/devices/rtc.py and 1 other location - About 1 hr to fix
            ducky/devices/svga.py on lines 36..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 41.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status