Sign upLogin

happz/ducky

View on GitHub
Star
ducky/tools/vm.py

Summary

Maintainability
D
1 day
Test Coverage

File vm.py has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import six.moves
import urllib

if not hasattr(urllib, 'parse'):
  urllib.parse = six.moves.urllib.parse
Severity: Minor
Found in ducky/tools/vm.py - About 4 hrs to fix

    Function main has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    def main():
  from . import add_common_options, parse_options

  parser = optparse.OptionParser()
  add_common_options(parser)
    Severity: Minor
    Found in ducky/tools/vm.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function process_config_options has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def process_config_options(logger, options, config_file = None, set_options = None, add_options = None, enable_devices = None, disable_devices = None):
  """
  Load VM config file, and apply all necessary changes, as requested by command-line options.

  :param logging.Logger logger: ``Logger`` instance to use for logging.
    Severity: Minor
    Found in ducky/tools/vm.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def main():
  from . import add_common_options, parse_options

  parser = optparse.OptionParser()
  add_common_options(parser)
    Severity: Minor
    Found in ducky/tools/vm.py - About 1 hr to fix

      Function process_config_options has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def process_config_options(logger, options, config_file = None, set_options = None, add_options = None, enable_devices = None, disable_devices = None):
      Severity: Major
      Found in ducky/tools/vm.py - About 50 mins to fix

        Function read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def read(self, size = None):
    """
    See :py:meth:`ducky.streams.Stream.read`.

    """
        Severity: Minor
        Found in ducky/tools/vm.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def __init__(self, logger, options, config, *args, **kwargs):
        Severity: Minor
        Found in ducky/tools/vm.py - About 35 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

            config = process_config_options(logger,
                                  options,
                                  config_file = options.machine_config,
                                  set_options = [(section,) + tuple(option.split('=')) for section, option in (option.split(':') for option in options.set_options)],
          Severity: Major
          Found in ducky/tools/vm.py and 3 other locations - About 1 hr to fix
          ducky/tools/img.py on lines 71..73
          ducky/tools/img.py on lines 71..74
          ducky/tools/vm.py on lines 410..414

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status