ducky/util.py
File util.py
has 266 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import collections
import functools
import string
from six import iteritems, integer_types, PY2
Function do_open
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def do_open(logger, path, mode = 'rb', klass = None):
if 'b' not in mode:
mode += 'b'
stream = open(path, mode)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __getitem__
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def __getitem__(self, address):
last_symbol = None
last_symbol_offset = 0xFFFE
for symbol_name, symbol in iteritems(self.binary.symbols):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
Open
return '{:d}'.format(i)