haraka/haraka-plugin-access

View on GitHub

Showing 29 of 29 total issues

Avoid too many return statements within this function.
Open

    return next()
Severity: Major
Found in index.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          if (params && params[0]) return params[0].host
    Severity: Major
    Found in index.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return next(DENY, `${rcpt_to} ${this.cfg.deny_msg.rcpt}`)
      Severity: Major
      Found in index.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return next()
        Severity: Major
        Found in index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return next()
          Severity: Major
          Found in index.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return next(DENY, `${mail_from} ${this.cfg.deny_msg.mail}`)
            Severity: Major
            Found in index.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return next(DENY, `${rcpt_to} ${this.cfg.deny_msg.rcpt}`)
              Severity: Major
              Found in index.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return next(DENY, `${mail_from} ${this.cfg.deny_msg.mail}`)
                Severity: Major
                Found in index.js - About 30 mins to fix

                  Function register has a Cognitive Complexity of 12 (exceeds 11 allowed). Consider refactoring.
                  Open

                  exports.register = function () {
                    this.init_config() // init this.cfg
                    this.init_lists()
                    this.load_access_ini() // update with *.ini settings
                  
                  
                  Severity: Minor
                  Found in index.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language