Sign upLogin

haraka/haraka-plugin-attachment

View on GitHub
Star

Showing 19 of 19 total issues

File index.js has 602 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const fs = require('fs');
const path = require('path');
const { spawn } = require('child_process');
Severity: Major
Found in index.js - About 1 day to fix

    Function unarchive_recursive has 184 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.unarchive_recursive = async function (
  connection,
  f,
  archive_file_name,
  cb,
    Severity: Major
    Found in index.js - About 7 hrs to fix

      Function unarchive_recursive has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.unarchive_recursive = async function (
  connection,
  f,
  archive_file_name,
  cb,
      Severity: Minor
      Found in index.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function start_attachment has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.start_attachment = function (
  connection,
  ctype,
  filename,
  body,
      Severity: Major
      Found in index.js - About 3 hrs to fix

        Function check_attachments has 73 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.check_attachments = function (next, connection) {
  const txn = connection?.transaction;
  if (!txn) return next();

  // Check for any stored errors from the attachment hooks
        Severity: Major
        Found in index.js - About 2 hrs to fix

          Function check_attachments has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.check_attachments = function (next, connection) {
  const txn = connection?.transaction;
  if (!txn) return next();

  // Check for any stored errors from the attachment hooks
          Severity: Minor
          Found in index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function timeoutedSpawn has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function timeoutedSpawn(cmd_path, args, env, pipe_stdout_ws) {
    connection.logdebug(plugin, `running "${cmd_path} ${args.join(' ')}"`);

    return new Promise(function (resolve, reject) {
      let output = '';
          Severity: Minor
          Found in index.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              if (ctypes_result) {
    connection.loginfo(
      this,
      `match ctype="${ctypes_result[0]}" regexp=/${ctypes_result[1]}/`,
    );
            Severity: Major
            Found in index.js and 2 other locations - About 1 hr to fix
            index.js on lines 679..688
            index.js on lines 695..704

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              if (archives_result) {
    connection.loginfo(
      this,
      `match file="${archives_result[0]}" regexp=/${archives_result[1]}/`,
    );
            Severity: Major
            Found in index.js and 2 other locations - About 1 hr to fix
            index.js on lines 666..675
            index.js on lines 679..688

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              if (files_result) {
    connection.loginfo(
      this,
      `match file="${files_result[0]}" regexp=/${files_result[1]}/`,
    );
            Severity: Major
            Found in index.js and 2 other locations - About 1 hr to fix
            index.js on lines 666..675
            index.js on lines 695..704

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function load_attachment_ini has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.load_attachment_ini = function () {
  const plugin = this;

  plugin.cfg = plugin.config.get('attachment.ini', () => {
    plugin.load_attachment_ini();
            Severity: Minor
            Found in index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function compute_and_log_md5sum has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.compute_and_log_md5sum = function (
  connection,
  ctype,
  filename,
  stream,
            Severity: Minor
            Found in index.js - About 1 hr to fix

              Function unpackArchive has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                async function unpackArchive(in_file, file) {
    const t = await createTmp();
    tmpfiles.push([t.fd, t.name]);

    connection.logdebug(
              Severity: Minor
              Found in index.js - About 1 hr to fix

                Function listFiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  async function listFiles(in_file, prefix, depth) {
    const result = [];
    depth = depth || 0;

    if (timeouted) {
                Severity: Minor
                Found in index.js - About 1 hr to fix

                  Function check_items_against_regexps has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.check_items_against_regexps = function (items, regexps) {
  if (!Array.isArray(regexps) || !Array.isArray(items)) return false;
  if (!regexps?.length || !items?.length) return false;

  for (let r = 0; r < regexps.length; r++) {
                  Severity: Minor
                  Found in index.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function start_attachment has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    connection,
  ctype,
  filename,
  body,
  stream,
                  Severity: Minor
                  Found in index.js - About 35 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return next(
      DENY,
      `Message contains unacceptable attachment (${files_result[0]})`,
    );
                    Severity: Major
                    Found in index.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return next(
      DENY,
      `Message contains unacceptable attachment (${archives_result[0]})`,
    );
                      Severity: Major
                      Found in index.js - About 30 mins to fix

                        Function start_attachment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        exports.start_attachment = function (
  connection,
  ctype,
  filename,
  body,
                        Severity: Minor
                        Found in index.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language