Sign upLogin

haraka/haraka-plugin-auth-imap

View on GitHub
Star

Showing 2 of 2 total issues

Function check_plain_passwd has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.check_plain_passwd = function (connection, user, passwd, cb) {
    const plugin = this;
    let trace_imap = false;
    const domain = (user.split('@'))[1];
    let sect = plugin.cfg.main;
Severity: Major
Found in index.js - About 3 hrs to fix

    Function check_plain_passwd has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.check_plain_passwd = function (connection, user, passwd, cb) {
    const plugin = this;
    let trace_imap = false;
    const domain = (user.split('@'))[1];
    let sect = plugin.cfg.main;
    Severity: Minor
    Found in index.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language