Sign upLogin

haraka/haraka-plugin-dcc

View on GitHub
Star

Showing 2 of 2 total issues

Function hook_data_post has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.hook_data_post = function (next, connection) {
    const plugin = this;

    // Fix-up rDNS for DCC
    const training = plugin.should_train(connection.transaction);
Severity: Minor
Found in index.js - About 1 hr to fix

    Function get_response_headers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.get_response_headers = function (c, rl) {
    // Read headers
    const headers = [];
    for (let i=0; i<rl.length; i++) {
        if (/^\s/.test(rl[i]) && headers.length) {
    Severity: Minor
    Found in index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language