Sign upLogin

haraka/haraka-plugin-dkim

View on GitHub
Star

Showing 60 of 60 total issues

Function hook_pre_send_trans_email has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.hook_pre_send_trans_email = function (next, connection) {
  if (!this.cfg.sign.enabled) return next()
  if (!connection?.transaction) return next()

  if (connection.transaction.notes?.dkim_signed) {
Severity: Minor
Found in index.js - About 1 hr to fix

    Function hook_pre_send_trans_email has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.hook_pre_send_trans_email = function (next, connection) {
  if (!this.cfg.sign.enabled) return next()
  if (!connection?.transaction) return next()

  if (connection.transaction.notes?.dkim_signed) {
    Severity: Minor
    Found in index.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                if (!match) continue
    Severity: Major
    Found in lib/dkim.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if (!this.header_idx[hn]) this.header_idx[hn] = []
      Severity: Major
      Found in lib/dkim.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    if (this.pending === 0) {
              process.nextTick(() => {
                if (self.cb) self.cb(new Error('no signatures found'))
              })
            }
        Severity: Major
        Found in lib/dkim.js - About 45 mins to fix

          Function add_body_line has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            add_body_line(line) {
    if (this.run_cb) return

    if (this.bodycanon === 'relaxed') {
      line = DKIMObject.canonicalize(line)
          Severity: Minor
          Found in lib/dkim.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                      for (const dkimHeader of dkim_headers) {
              this.dkim_objects.push(
                new DKIMObject(
                  dkimHeader,
                  this.header_idx,
          Severity: Major
          Found in lib/dkim.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (h_md5 === this.sig_md5) {
              this.debug(`${this.identity}: skipped our own DKIM-Signature`)
              continue
            }
            Severity: Major
            Found in lib/dkim.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (!header_name) continue
              Severity: Major
              Found in lib/dkim.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                              if (i.toLowerCase() !== this.fields.d.toLowerCase()) {
                return this.result(
                  'i/d selector domain mismatch (t=s)',
                  'invalid',
                )
                Severity: Major
                Found in lib/dkim.js - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if (!props.selector) {
        connection.transaction.results.add(this, {
          err: `missing selector for domain ${domain}`,
        })
      }
                  Severity: Minor
                  Found in index.js and 1 other location - About 40 mins to fix
                  index.js on lines 149..153

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 48.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if (!props.private_key) {
        connection.transaction.results.add(this, {
          err: `missing dkim private_key for domain ${domain}`,
        })
      }
                  Severity: Minor
                  Found in index.js and 1 other location - About 40 mins to fix
                  index.js on lines 144..148

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 48.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function end has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    end(buf) {
    this.writable = false

    // Add trailing CRLF if we have data left over
    if (this.buffer.ar.length) {
                  Severity: Minor
                  Found in lib/dkim.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function has_key_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.has_key_data = function (conn, props) {
  let missing = undefined

  // Make sure we have all the relevant configuration
  if (!props.private_key) {
                  Severity: Minor
                  Found in index.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this function.
                  Open

                          return this.result('invalid expiration date', 'invalid')
                  Severity: Major
                  Found in lib/dkim.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      return domain
                    Severity: Major
                    Found in index.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return domain
                      Severity: Major
                      Found in index.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return this.result(
          'creation date is invalid or in the future',
          'invalid',
        )
                        Severity: Major
                        Found in lib/dkim.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              if (!this.fields.d) return this.result('domain missing', 'invalid')
                          Severity: Major
                          Found in lib/dkim.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return this.result('signed headers missing', 'invalid')
                            Severity: Major
                            Found in lib/dkim.js - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language