Issues - haraka/haraka-plugin-spf

Avoid deeply nested control flow statements.
Open

            if (this.ipaddr.match(range, cidr)) {
              this.log_debug(
                `mech_mx: ${this.ip} => ${address}/${cidr}: MATCH!`,
              )
              return this.return_const(qualifier)

Found in lib/spf.js - About 45 mins to fix

Avoid too many `return` statements within this function.
Open

      return next()

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    return this.SPF_NEUTRAL // default if no more mechanisms

Found in lib/spf.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

            return this.return_const(qualifier)

Found in lib/spf.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

            return this.SPF_NONE

Found in lib/spf.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    if (timeout) return

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return plugin.return_results(
        next,
        connection,
        spf,
        'helo',

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

  if (!host) return next() // null-sender

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return this.SPF_PERMERROR

Found in lib/spf.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return next()

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    if (!connection.relaying) return ch_cb(null, result)

Found in index.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      if (result && result !== this.SPF_NONE) return result

Found in lib/spf.js - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (args && (cm = /\/(\d+)((?:\/\/(\d+))?)$/.exec(args))) {
      cidr4 = cm[1]
      cidr6 = cm[2]
    }

Found in lib/spf.js and 1 other location - About 30 mins to fix

Read up
Read up

lib/spf.js on lines 400..403

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

haraka/haraka-plugin-spf

Showing 68 of 68 total issues

Avoid deeply nested control flow statements.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Severity

Category

Status

Source

Language

haraka/haraka-plugin-spf

Showing 68 of 68 total issues

Avoid deeply nested control flow statements. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Severity

Category

Status

Source

Language

Avoid deeply nested control flow statements.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open