Sign upLogin

haraka/test-fixtures

View on GitHub
Star
lib/util_hmailitem.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function createHMailItem has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createHMailItem = function (outbound_context, options, callback) {
  const mail_from = options.mail_from || 'sender@domain'
  const delivery_domain = options.delivery_domain || 'domain'
  const mail_recipients = options.mail_recipients || [
    new Address('recipient@domain'),
Severity: Major
Found in lib/util_hmailitem.js - About 2 hrs to fix

    Function playTestSmtpConversation has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.playTestSmtpConversation = function (
  hmail,
  socket,
  test,
  playbook,
    Severity: Minor
    Found in lib/util_hmailitem.js - About 1 hr to fix

      Function write has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        socket.write = function (line) {
    //console.log('MockSocket.write(' + line.replace(/\n/, '\\n').replace(/\r/, '\\r') + ')');
    if (playbook.length == 0) {
      test.ok(false, 'missing next playbook entry')
      test.done()
      Severity: Minor
      Found in lib/util_hmailitem.js - About 1 hr to fix

        Function playTestSmtpConversation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.playTestSmtpConversation = function (
  hmail,
  socket,
  test,
  playbook,
        Severity: Minor
        Found in lib/util_hmailitem.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function playTestSmtpConversation has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          hmail,
  socket,
  test,
  playbook,
  callback,
        Severity: Minor
        Found in lib/util_hmailitem.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status