Sign upLogin

haraka/test-fixtures

View on GitHub
Star

Showing 29 of 29 total issues

Function constructor has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(client, server, cfg) {
    this.client = client
    this.server = server
    this.cfg = cfg
Severity: Major
Found in lib/connection.js - About 3 hrs to fix

    Function end_data has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      end_data(cb) {
    if (!this.found_hb_sep && this.header_lines.length) {
      // Headers not parsed yet - must be a busted email
      // Strategy: Find the first line that doesn't look like a header.
      // Treat anything before that as headers, anything after as body.
    Severity: Minor
    Found in lib/transaction.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_dot_stuffing_and_ensure_crlf_newlines has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      add_dot_stuffing_and_ensure_crlf_newlines(data) {
    if (!data.length) return data
    if (!Buffer.isBuffer(data)) data = Buffer.from(data)

    // Make a new buffer big enough to hold two bytes for every one input
    Severity: Minor
    Found in lib/transaction.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_data has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      add_data(line) {
    if (typeof line === 'string') {
      // This shouldn't ever happen...
      line = Buffer.from(line, this.encoding)
    }
    Severity: Minor
    Found in lib/transaction.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setupClient has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static setupClient(self) {
    if (Object.keys(self.client).length === 0) return
    const ip = self.client.remoteAddress
    if (!ip) {
      self.logdebug('setupClient got no IP address for this connection!')
    Severity: Major
    Found in lib/connection.js - About 2 hrs to fix

      Function createHMailItem has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.createHMailItem = function (outbound_context, options, callback) {
  const mail_from = options.mail_from || 'sender@domain'
  const delivery_domain = options.delivery_domain || 'domain'
  const mail_recipients = options.mail_recipients || [
    new Address('recipient@domain'),
      Severity: Major
      Found in lib/util_hmailitem.js - About 2 hrs to fix

        Function log_if_level has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        logger.log_if_level = function (level, key, plugin) {
  return function () {
    if (logger.loglevel < logger[key]) return
    const levelstr = `[${level}]`
    let str = ''
        Severity: Minor
        Found in lib/logger.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function playTestSmtpConversation has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.playTestSmtpConversation = function (
  hmail,
  socket,
  test,
  playbook,
        Severity: Minor
        Found in lib/util_hmailitem.js - About 1 hr to fix

          Function _get_plugin_path has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _get_plugin_path(name) {
    this.hasPackageJson = false
    if (!name) name = this.name

    const paths = []
          Severity: Minor
          Found in lib/plugin.js - About 1 hr to fix

            Function add_dot_stuffing_and_ensure_crlf_newlines has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              add_dot_stuffing_and_ensure_crlf_newlines(data) {
    if (!data.length) return data
    if (!Buffer.isBuffer(data)) data = Buffer.from(data)

    // Make a new buffer big enough to hold two bytes for every one input
            Severity: Minor
            Found in lib/transaction.js - About 1 hr to fix

              Function write has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                socket.write = function (line) {
    //console.log('MockSocket.write(' + line.replace(/\n/, '\\n').replace(/\r/, '\\r') + ')');
    if (playbook.length == 0) {
      test.ok(false, 'missing next playbook entry')
      test.done()
              Severity: Minor
              Found in lib/util_hmailitem.js - About 1 hr to fix

                Function _get_plugin_path has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                  _get_plugin_path(name) {
    this.hasPackageJson = false
    if (!name) name = this.name

    const paths = []
                Severity: Minor
                Found in lib/plugin.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  constructor(uuid, cfg) {
    this.uuid = uuid || '111111-222222-333-4444444'
    this.cfg = cfg
    this.mail_from = null
    this.rcpt_to = []
                Severity: Minor
                Found in lib/transaction.js - About 1 hr to fix

                  Function end_data has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    end_data(cb) {
    if (!this.found_hb_sep && this.header_lines.length) {
      // Headers not parsed yet - must be a busted email
      // Strategy: Find the first line that doesn't look like a header.
      // Treat anything before that as headers, anything after as body.
                  Severity: Minor
                  Found in lib/transaction.js - About 1 hr to fix

                    Function playTestSmtpConversation has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                    exports.playTestSmtpConversation = function (
  hmail,
  socket,
  test,
  playbook,
                    Severity: Minor
                    Found in lib/util_hmailitem.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function add_data has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      add_data(line) {
    if (typeof line === 'string') {
      // This shouldn't ever happen...
      line = Buffer.from(line, this.encoding)
    }
                    Severity: Minor
                    Found in lib/transaction.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          self.client.on('close', (has_error) => {
      if (self.state >= states.DISCONNECTING) return
      self.remote.closed = true
      self.loginfo('client dropped connection', log_data)
      self.fail()
                      Severity: Major
                      Found in lib/connection.js and 1 other location - About 1 hr to fix
                      lib/connection.js on lines 136..141

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          self.client.on('end', () => {
      if (self.state >= states.DISCONNECTING) return
      self.remote.closed = true
      self.loginfo('client half closed connection', log_data)
      self.fail()
                      Severity: Major
                      Found in lib/connection.js and 1 other location - About 1 hr to fix
                      lib/connection.js on lines 143..148

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                        set(prop_str, val) {
    if (arguments.length === 3) {
      prop_str = `${arguments[0]}.${arguments[1]}`
      val = arguments[2]
    }
                      Severity: Minor
                      Found in lib/connection.js - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        add_leading_header(key, value) {
    this.header.add(key, value)
    if (this.header_pos > 0) this.reset_headers()
  }
                      Severity: Minor
                      Found in lib/transaction.js and 1 other location - About 40 mins to fix
                      lib/transaction.js on lines 220..223

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language