hardpixel/tm2gsv

View on GitHub

Showing 3 of 3 total issues

Method parse_files has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def parse_files
        unless File.exist? @source
          @task.say "Error: No such file or directory!", :red
          exit(1)
        end
Severity: Minor
Found in lib/tm2gsv/theme.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_setting_styles has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def parse_setting_styles(key, value)
        settings = @settings.first['settings']
        theme_styles = @theme[:styles]
        styles = {}

Severity: Minor
Found in lib/tm2gsv/theme/parser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_styles has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def create_styles(styles)
        styles.each do |key, value|
          next if value.empty?

          elem = ::Ox::Element.new('style')
Severity: Minor
Found in lib/tm2gsv/theme/writer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language