haroldtreen/epub-press

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static updateSectionsHtml(book) {
        tracker.setStatus(book.getId(), STATUS_TYPES.FETCHING_HTML);
        const sections = book.getSections();
        return new Promise((resolve) => {
            Promise.all(sections.map((section) => BookServices.updateSectionHtml(section)))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static convertSectionsContent(book) {
        tracker.setStatus(book.getId(), STATUS_TYPES.FORMATTING_HTML);
        const sections = book.getSections();
        return new Promise((resolve) => {
            Promise.all(sections.map((section) => BookServices.convertSectionContent(section)))

• Read up
  Read up

Book has 30 functions (exceeds 20 allowed). Consider refactoring.

Open

class Book {
    static find(id, filetype) {
        return new Promise((resolve, reject) => {
            BookModel.findOne({ where: { uid: id } }).then((bookModel) => {
                if (!bookModel) {

HtmlProcessor has 27 functions (exceeds 20 allowed). Consider refactoring.

Open

class HtmlProcessor {
    /*
     *   Image extraction
     */

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    if (isEmail) {
                        const mailerFn = isMobi ? Mailer.sendMobi : Mailer.sendEpub;
                        return mailerFn(req.query.email, book).catch((error) => {
                            log.warn('Book delivery failed', req.query, error);
                            res.status(500).send('Email failed');

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                .then((book) => {
                    const mailerFn = isMobi ? Mailer.sendMobi : Mailer.sendEpub;
                    return mailerFn(req.query.email, book).catch((error) => {
                        log.warn('Book delivery failed', req.query, error);
                        res.status(500).send('Email failed');

• Read up
  Read up

File html-processor.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.

Open

const path = require('path');
const Url = require('url');

const cheerio = require('cheerio');
const stringDirection = require('string-direction');

File book.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.

Open

'use strict';

const fs = require('fs');

const shortid = require('shortid');

File book-services.js has 253 lines of code (exceeds 250 allowed). Consider refactoring.

Open

'use strict';

const { exec } = require('child_process');
const request = require('request-promise').defaults({ gzip: true });
const { tidy } = require('htmltidy2');

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static sendMobi(email, book) {
        const mailOptions = getMailOptions(email, book);
        mailOptions.attachments = [{ filename: 'EpubPress.mobi', path: book.getMobiPath() }];
        return Mailer.sendMail(mailOptions);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static sendEpub(email, book) {
        const mailOptions = getMailOptions(email, book);
        mailOptions.attachments = [{ filename: 'EpubPress.epub', path: book.getEpubPath() }];
        return Mailer.sendMail(mailOptions);
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static preprocess(html) {
        return new Promise((resolve) => {
            const operations = ContentExtractor.preprocess.OPERATIONS;

            const preHtml = HtmlProcessor.runHtmlOperations(html, operations);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    static postprocess(html) {
        return new Promise((resolve) => {
            const operations = ContentExtractor.postprocess.OPERATIONS;

            const postHtml = HtmlProcessor.runHtmlOperations(html, operations);

• Read up
  Read up

Function writeEpub has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    writeEpub() {
        this._ebook = Book.getEpubWriter(this.getMetadata());

        this.getSections().forEach((section) => {
            if (section.title && section.xhtml) {

Function bookFromBody has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function bookFromBody(body) {
    return new Promise((resolve) => {
        const sections = [];
        if (body.urls) {
            log.verbose('Urls request');

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                {
                    id: 1,
                    title: 'Seed Book 1',
                    sections: JSON.stringify([
                        { title: 'Colombia', url: 'http://wikitravel.org/en/Colombia' },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                {
                    id: 2,
                    title: 'Seed Book 2',
                    sections: JSON.stringify([
                        { title: 'Ecuador', url: 'http://wikitravel.org/en/Ecuador' },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (percent <= ResultsValidator.LENGTH_THRESHOLD) {
            log.warn(`Remaining content ${percent}%`, { url: this.url });
            return false;
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (percent <= ResultsValidator.PARAGRAPH_THRESHOLD) {
            log.warn(`Remaining paragraphs ${percent}%`, { url: this.url });
            return false;
        }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    static replaceWithChildren(selector, html) {
        return HtmlProcessor._proccessElements(selector, html, ($elem) => {
            $elem.replaceWith($elem.children());
        });
    }

• Read up
  Read up