Sign upLogin

haru/redmine_code_review

View on GitHub
Star
app/models/code_review.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class CodeReview has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class CodeReview < ActiveRecord::Base
  include Redmine::SafeAttributes
  belongs_to :project
  belongs_to :change
  belongs_to :issue
Severity: Minor
Found in app/models/code_review.rb - About 2 hrs to fix

    Method path has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def path
    begin
      return file_path if file_path
      return @path if @path
      if attachment_id
    Severity: Minor
    Found in app/models/code_review.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return ex.to_s
    Severity: Major
    Found in app/models/code_review.rb - About 30 mins to fix

      Method open_assignment_issues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def open_assignment_issues(user_id)
    issues = []
    assignments = []
    assignments = change.code_review_assignments if change
    assignments = assignments + changeset.code_review_assignments if changeset
      Severity: Minor
      Found in app/models/code_review.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status