Sign upLogin

haru/redmine_code_review

View on GitHub
Star
lib/code_review_auto_assign_settings.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class AutoAssignSettings has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class AutoAssignSettings
    def initialize(yml_string = nil)
      yml_string = {:enabled => false}.to_yaml if yml_string.blank?
      load_yml(yml_string)
    end
Severity: Minor
Found in lib/code_review_auto_assign_settings.rb - About 3 hrs to fix

    Method select_assign_to_with_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def select_assign_to_with_list(project, list, commiter_id = nil)
      return nil unless list
      return nil if list.empty?
      list.collect! { |item| item.to_i }
      list.delete(commiter_id)
    Severity: Minor
    Found in lib/code_review_auto_assign_settings.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status