Sign upLogin

haru/redmine_wiki_extensions

View on GitHub
Star

Showing 26 of 26 total issues

Function tablesorter has 562 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function () {

            var parsers = [],
                widgets = [];
Severity: Major
Found in assets/javascripts/jquery.tablesorter.js - About 2 days to fix

    File jquery.tablesorter.js has 706 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * 
 * TableSorter 2.0 - Client-side table sorting with ease!
 * Version 2.0.5b
 * @requires jQuery v1.2.3
    Severity: Major
    Found in assets/javascripts/jquery.tablesorter.js - About 1 day to fix

      Method display_comments_tree has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
      Open

            def display_comments_tree(comments_tree, parent_id,page,data,k = 0)
          ret = ' '
          
        if k != 0
          ret << '<ul class="list" onClick="Check();">'
      Severity: Minor
      Found in lib/wiki_extensions_helper.rb - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method display_comments_tree has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def display_comments_tree(comments_tree, parent_id,page,data,k = 0)
          ret = ' '
          
        if k != 0
          ret << '<ul class="list" onClick="Check();">'
      Severity: Major
      Found in lib/wiki_extensions_helper.rb - About 4 hrs to fix

        Function construct has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    this.construct = function (settings) {
                return this.each(function () {
                    // if no thead or tbody quit.
                    if (!this.tHead || !this.tBodies) return;
                    // declare
        Severity: Major
        Found in assets/javascripts/jquery.tablesorter.js - About 3 hrs to fix

          Function draw has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              draw: function () {
        if (!this.scope) return null;

        this.tooltip = document.createElement('div');
        if (this.className)
          Severity: Minor
          Found in assets/javascripts/wiki_smiles.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function draw has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              draw: function () {
        if (!this.scope) return null;

        this.tooltip = document.createElement('div');
        if (this.className)
          Severity: Minor
          Found in assets/javascripts/wiki_smiles.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            for (var i = 0; i < l; i++) {
                    if (widgets[i].id.toLowerCase() == name.toLowerCase()) {
                        return widgets[i];
                    }
                }
            Severity: Major
            Found in assets/javascripts/jquery.tablesorter.js and 1 other location - About 1 hr to fix
            assets/javascripts/jquery.tablesorter.js on lines 238..242

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            for (var i = 0; i < l; i++) {
                    if (parsers[i].id.toLowerCase() == name.toLowerCase()) {
                        return parsers[i];
                    }
                }
            Severity: Major
            Found in assets/javascripts/jquery.tablesorter.js and 1 other location - About 1 hr to fix
            assets/javascripts/jquery.tablesorter.js on lines 514..518

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function computeTableHeaderCellIndexes has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        function computeTableHeaderCellIndexes(t) {
                var matrix = [];
                var lookup = {};
                var thead = t.getElementsByTagName('THEAD')[0];
                var trs = thead.getElementsByTagName('TR');
            Severity: Minor
            Found in assets/javascripts/jquery.tablesorter.js - About 1 hr to fix

              Function do_some has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

              function do_some(src, evt) {
    if (!Firefox) {
        cls = src.parentNode.className;
        if (cls=='list_item ExpandOpen') {
            src.parentNode.className = 'list_item ExpandClosed';
              Severity: Minor
              Found in assets/javascripts/wiki_extensions.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function appendToTable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          function appendToTable(table, cache) {

                if (table.config.debug) {
                    var appendTime = new Date()
                }
              Severity: Minor
              Found in assets/javascripts/jquery.tablesorter.js - About 1 hr to fix

                Function multisort has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            function multisort(table, sortList, cache) {

                if (table.config.debug) {
                    var sortTime = new Date();
                }
                Severity: Minor
                Found in assets/javascripts/jquery.tablesorter.js - About 1 hr to fix

                  Function buildParserCache has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              function buildParserCache(table, $headers) {

                if (table.config.debug) {
                    var parsersDebug = "";
                }
                  Severity: Minor
                  Found in assets/javascripts/jquery.tablesorter.js - About 1 hr to fix

                    Function buildCache has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                function buildCache(table) {

                if (table.config.debug) {
                    var cacheTime = new Date();
                }
                    Severity: Minor
                    Found in assets/javascripts/jquery.tablesorter.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  function sortText(a, b) {
                if (table.config.sortLocaleCompare) return a.localeCompare(b);
                return ((a < b) ? -1 : ((a > b) ? 1 : 0));
            };
                      Severity: Major
                      Found in assets/javascripts/jquery.tablesorter.js and 1 other location - About 1 hr to fix
                      assets/javascripts/jquery.tablesorter.js on lines 671..674

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  function sortTextDesc(a, b) {
                if (table.config.sortLocaleCompare) return b.localeCompare(a);
                return ((b < a) ? -1 : ((b > a) ? 1 : 0));
            };
                      Severity: Major
                      Found in assets/javascripts/jquery.tablesorter.js and 1 other location - About 1 hr to fix
                      assets/javascripts/jquery.tablesorter.js on lines 666..669

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                                      } else if (type == 'numeric' && direction == 'desc') {
                    return "(" + a + " === null && " + b + " === null) ? 0 :(" + a + " === null ? Number.POSITIVE_INFINITY : (" + b + " === null ? Number.NEGATIVE_INFINITY : " + b + " - " + a + "));";
                }
                      Severity: Major
                      Found in assets/javascripts/jquery.tablesorter.js and 3 other locations - About 1 hr to fix
                      assets/javascripts/jquery.tablesorter.js on lines 639..647
                      assets/javascripts/jquery.tablesorter.js on lines 641..647
                      assets/javascripts/jquery.tablesorter.js on lines 643..647

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 55.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                                      if (type == 'text' && direction == 'asc') {
                    return "(" + a + " == " + b + " ? 0 : (" + a + " === null ? Number.POSITIVE_INFINITY : (" + b + " === null ? Number.NEGATIVE_INFINITY : (" + a + " < " + b + ") ? -1 : 1 )));";
                } else if (type == 'text' && direction == 'desc') {
                    return "(" + a + " == " + b + " ? 0 : (" + a + " === null ? Number.POSITIVE_INFINITY : (" + b + " === null ? Number.NEGATIVE_INFINITY : (" + b + " < " + a + ") ? -1 : 1 )));";
                } else if (type == 'numeric' && direction == 'asc') {
                      Severity: Major
                      Found in assets/javascripts/jquery.tablesorter.js and 3 other locations - About 1 hr to fix
                      assets/javascripts/jquery.tablesorter.js on lines 641..647
                      assets/javascripts/jquery.tablesorter.js on lines 643..647
                      assets/javascripts/jquery.tablesorter.js on lines 645..647

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 55.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 4 locations. Consider refactoring.
                      Open

                                      } else if (type == 'text' && direction == 'desc') {
                    return "(" + a + " == " + b + " ? 0 : (" + a + " === null ? Number.POSITIVE_INFINITY : (" + b + " === null ? Number.NEGATIVE_INFINITY : (" + b + " < " + a + ") ? -1 : 1 )));";
                } else if (type == 'numeric' && direction == 'asc') {
                    return "(" + a + " === null && " + b + " === null) ? 0 :(" + a + " === null ? Number.POSITIVE_INFINITY : (" + b + " === null ? Number.NEGATIVE_INFINITY : " + a + " - " + b + "));";
                } else if (type == 'numeric' && direction == 'desc') {
                      Severity: Major
                      Found in assets/javascripts/jquery.tablesorter.js and 3 other locations - About 1 hr to fix
                      assets/javascripts/jquery.tablesorter.js on lines 639..647
                      assets/javascripts/jquery.tablesorter.js on lines 643..647
                      assets/javascripts/jquery.tablesorter.js on lines 645..647

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 55.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language