Sign upLogin

hauntd/help-center

View on GitHub
Star
modules/management/views/user/update.php

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            <?= $this->render('_form', [
                'user' => $user,
                'helper' => $helper,
                'formId' => 'user-update-form',
                'buttons' => [
Severity: Major
Found in modules/management/views/user/update.php and 1 other location - About 1 hr to fix
modules/management/views/post/update.php on lines 20..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Only one argument is allowed per line in a multi-line function call
Open

                <?= Html::a('&larr; ' . Yii::t('app', 'Back to users'), ['index'],
Severity: Minor
Found in modules/management/views/user/update.php by phpcodesniffer

Opening parenthesis of a multi-line function call must be the last content on the line
Open

                <?= Html::a('&larr; ' . Yii::t('app', 'Back to users'), ['index'],
Severity: Minor
Found in modules/management/views/user/update.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

                    ['class' => 'btn btn-xs btn-ghost btn-default btn-modal-close']) ?>
Severity: Minor
Found in modules/management/views/user/update.php by phpcodesniffer

Multi-line function call not indented correctly; expected 16 spaces but found 20
Open

                    ['class' => 'btn btn-xs btn-ghost btn-default btn-modal-close']) ?>
Severity: Minor
Found in modules/management/views/user/update.php by phpcodesniffer

There are no issues that match your filters.

Category
Status