Sign upLogin

hauntd/yii2-vote

View on GitHub
Star
models/Vote.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class 'hauntd\vote\models\VoteAggregate' in method 'updateRating'.
Open

        $aggregateModel = VoteAggregate::findOne([
            'entity' => $entity,
            'target_id' => $targetId,
        ]);
Severity: Minor
Found in models/Vote.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method updateRating uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $rating = 0;
        }
Severity: Minor
Found in models/Vote.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

There are no issues that match your filters.

Category
Status